directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: r493145 - in /directory/branches/shared/0.9.5/ldap/src: main/antlr/filter-parser.g test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java
Date Fri, 05 Jan 2007 19:14:23 GMT
Author: akarasulu
Date: Fri Jan  5 11:14:23 2007
New Revision: 493145

URL: http://svn.apache.org/viewvc?view=rev&rev=493145
Log:
fixing bug where recognition exceptions were being swallowed up by the default error handler
of the filter parser

Modified:
    directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g
    directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java

Modified: directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g
URL: http://svn.apache.org/viewvc/directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g?view=diff&rev=493145&r1=493144&r2=493145
==============================================================================
--- directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g (original)
+++ directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g Fri Jan  5 11:14:23
2007
@@ -51,6 +51,7 @@
 {
     k = 5;
 	importVocab = FilterLexer;
+	defaultErrorHandler=false;
 }
 
 

Modified: directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java
URL: http://svn.apache.org/viewvc/directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java?view=diff&rev=493145&r1=493144&r2=493145
==============================================================================
--- directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java
(original)
+++ directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java
Fri Jan  5 11:14:23 2007
@@ -175,22 +175,21 @@
         assertEquals( AbstractExprNode.EQUALITY, node.getAssertionType() );
     }
 
-    /*
+
     public void testBadEqualsFilter() throws IOException, ParseException
     {
         try
         {
-            SimpleNode node = ( SimpleNode ) parser.parse( "ou = people" );
+            parser.parse( "ou = people" );
             
             // The parsing should fail
-            fail();
+            fail( "should fail with bad filter" );
         }
         catch( ParseException pe )
         {
-            assertTrue( true );
         }
     }
-    */
+
 
     public void testEqualsWithForwardSlashFilter() throws IOException, ParseException
     {



Mime
View raw message