Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 44001 invoked from network); 15 Nov 2006 14:39:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Nov 2006 14:39:31 -0000 Received: (qmail 73130 invoked by uid 500); 15 Nov 2006 14:39:41 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 73102 invoked by uid 500); 15 Nov 2006 14:39:40 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 73090 invoked by uid 99); 15 Nov 2006 14:39:40 -0000 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2006 06:39:40 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id 7EFCB1A9846; Wed, 15 Nov 2006 06:37:58 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r475246 - /directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java Date: Wed, 15 Nov 2006 14:37:58 -0000 To: commits@directory.apache.org From: jvermillard@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061115143758.7EFCB1A9846@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jvermillard Date: Wed Nov 15 06:37:57 2006 New Revision: 475246 URL: http://svn.apache.org/viewvc?view=rev&rev=475246 Log: using new StatCollector resume field for speedup serivce stat display Modified: directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java Modified: directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java URL: http://svn.apache.org/viewvc/directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java?view=diff&rev=475246&r1=475245&r2=475246 ============================================================================== --- directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java (original) +++ directory/branches/mina/1.0/integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java Wed Nov 15 06:37:57 2006 @@ -25,7 +25,6 @@ import org.apache.mina.common.IoService; import org.apache.mina.common.IoSession; -import org.apache.mina.management.IoSessionStat; import org.apache.mina.management.StatCollector; @@ -83,153 +82,49 @@ public float getTotalByteReadThroughput() { - float total = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getByteReadThroughput(); - } - } - return total; + return collector.getBytesReadThroughput(); } public float getTotalByteWrittenThroughput() { - float total = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getByteWrittenThroughput(); - } - } - return total; + return collector.getBytesWrittenThroughput(); } public float getTotalMessageReadThroughput() { - float total = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getMessageReadThroughput(); - } - } - return total; + return collector.getMsgReadThroughput(); } public float getTotalMessageWrittenThroughput() { - float total = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getMessageWrittenThroughput(); - } - } - return total; + return collector.getMsgWrittenThroughput(); } public float getAverageByteReadThroughput() { - float total = 0; - int count = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getByteReadThroughput(); - count++; - } - } - return total / count; + return collector.getBytesReadThroughput() / (float) collector.getSessionCount(); } public float getAverageByteWrittenThroughput() { - float total = 0; - int count = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getByteWrittenThroughput(); - count++; - } - } - return total / count; + return collector.getBytesWrittenThroughput() / (float) collector.getSessionCount(); } public float getAverageMessageReadThroughput() { - float total = 0; - int count = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getMessageReadThroughput(); - count++; - } - } - return total / count; + return collector.getMsgReadThroughput() / (float) collector.getSessionCount(); } public float getAverageMessageWrittenThroughput() { - float total = 0; - int count = 0; - for ( Iterator iter = service.getManagedServiceAddresses().iterator(); iter.hasNext(); ) - { - SocketAddress element = ( SocketAddress ) iter.next(); - - for ( Iterator iter2 = service.getManagedSessions( element ).iterator(); iter2.hasNext(); ) - { - IoSession session = ( IoSession ) iter2.next(); - total += ( ( IoSessionStat ) session.getAttribute( StatCollector.KEY ) ) - .getMessageWrittenThroughput(); - count++; - } - } - return total / count; + return collector.getMsgWrittenThroughput() / (float) collector.getSessionCount(); }