Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 53783 invoked from network); 7 Nov 2006 21:29:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2006 21:29:45 -0000 Received: (qmail 60382 invoked by uid 500); 7 Nov 2006 21:29:56 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 60332 invoked by uid 500); 7 Nov 2006 21:29:56 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 60321 invoked by uid 99); 7 Nov 2006 21:29:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 13:29:56 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 13:29:44 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id 762961A9846; Tue, 7 Nov 2006 13:29:17 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r472282 - /directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java Date: Tue, 07 Nov 2006 21:29:17 -0000 To: commits@directory.apache.org From: akarasulu@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061107212917.762961A9846@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: akarasulu Date: Tue Nov 7 13:29:16 2006 New Revision: 472282 URL: http://svn.apache.org/viewvc?view=rev&rev=472282 Log: cleaning up unnecessary wrapping of an add entry operation in a composite operation Modified: directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java Modified: directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java URL: http://svn.apache.org/viewvc/directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java?view=diff&rev=472282&r1=472281&r2=472282 ============================================================================== --- directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java (original) +++ directory/trunks/apacheds/mitosis/src/main/java/org/apache/directory/mitosis/operation/OperationFactory.java Tue Nov 7 13:29:16 2006 @@ -82,8 +82,6 @@ // Check an entry already exists. checkBeforeAdd( normalizedName ); - CompositeOperation result = new CompositeOperation( csn ); - // Insert 'entryUUID' and 'entryDeleted'. entry = ( Attributes ) entry.clone(); entry.remove( Constants.ENTRY_UUID ); @@ -96,8 +94,7 @@ // MODIFY operation) entry.put( Constants.ENTRY_CSN, csn.toOctetString() ); - result.add( new AddEntryOperation( csn, normalizedName, entry ) ); - return result; + return new AddEntryOperation( csn, normalizedName, entry ); }