Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 58354 invoked from network); 9 Sep 2005 22:41:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 9 Sep 2005 22:41:02 -0000 Received: (qmail 23799 invoked by uid 500); 9 Sep 2005 22:41:01 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 23760 invoked by uid 500); 9 Sep 2005 22:41:01 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 23747 invoked by uid 99); 9 Sep 2005 22:41:01 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2005 15:41:01 -0700 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 09 Sep 2005 15:41:14 -0700 Received: (qmail 58294 invoked by uid 65534); 9 Sep 2005 22:41:00 -0000 Message-ID: <20050909224100.58293.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r279900 - /directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java Date: Fri, 09 Sep 2005 22:41:00 -0000 To: commits@directory.apache.org From: elecharny@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: elecharny Date: Fri Sep 9 15:40:54 2005 New Revision: 279900 URL: http://svn.apache.org/viewcvs?rev=279900&view=rev Log: Fixed an error in equals method. As the value is stored in a byte, it should not be a simple comparaison. Modified: directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java Modified: directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java?rev=279900&r1=279899&r2=279900&view=diff ============================================================================== --- directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java (original) +++ directory/shared/ldap/trunk/common/src/java/org/apache/ldap/common/message/CompareRequestImpl.java Fri Sep 9 15:40:54 2005 @@ -253,7 +253,14 @@ if ( attrVal != null && req.getAssertionValue() != null ) { - if ( ! attrVal.equals( req.getAssertionValue() ) ) + try + { + if ( ! new String( attrVal, "UTF-8").equals( req.getAssertionValue() ) ) + { + return false; + } + } + catch ( UnsupportedEncodingException uee ) { return false; }