directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trus...@apache.org
Subject svn commit: r201594 - in /directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree: ./ jdbm/
Date Fri, 24 Jun 2005 11:32:00 GMT
Author: trustin
Date: Fri Jun 24 04:31:57 2005
New Revision: 201594

URL: http://svn.apache.org/viewcvs?rev=201594&view=rev
Log:
Removed TODOs without any explanation; it prevents me from looking for more important TODOs.

Modified:
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/DupsEnumeration.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Index.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexAssertionEnumeration.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexEnumeration.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/KeyOnlyComparator.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/NoDupsEnumeration.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Table.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/TupleEnumeration.java
    directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/jdbm/JdbmIndex.java

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/DupsEnumeration.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/DupsEnumeration.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/DupsEnumeration.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/DupsEnumeration.java
Fri Jun 24 04:31:57 2005
@@ -177,8 +177,6 @@
      * the values held in the TreeSet returned by the underlying enumeration.  
      * The values pulled off of this iterator are put into prefetched. 
      * </p>
-     *
-     * @throws NamingException TODO
      */
     private void prefetch() throws NamingException
     {

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Index.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Index.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Index.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Index.java
Fri Jun 24 04:31:57 2005
@@ -69,199 +69,57 @@
      */
     int count( Object attrVal ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param isGreaterThan TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     int count( Object attrVal, boolean isGreaterThan ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     BigInteger forwardLookup( Object attrVal )  throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param id TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     Object reverseLookup( BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param id TODO
-     * @throws NamingException TODO
-     */
     void add( Object attrVal, BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attr TODO
-     * @param id TODO
-     * @throws NamingException TODO
-     */
     void add( Attribute attr, BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrs TODO
-     * @param id TODO
-     * @throws NamingException TODO
-     */
     void add( Attributes attrs, BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param entryId TODO
-     * @throws NamingException TODO
-     */
     void drop( BigInteger entryId ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param id TODO
-     * @throws NamingException TODO
-     */
     void drop( Object attrVal, BigInteger id ) throws NamingException;
         
     /**
      * If the Attribute does not have any values then this reduces to a 
      * drop(BigInteger) call.
-     *
-     * @param attr TODO
-     * @param id TODO
-     * @throws NamingException TODO
      */
     void drop( Attribute attr, BigInteger id ) throws NamingException;
         
     /**
      * If the Attribute for this index within the Attributes does not have any 
      * values then this reduces to a drop(BigInteger) call.
-     *
-     * @param attrs TODO
-     * @param id TODO
-     * @throws NamingException TODO
      */
     void drop( Attributes attrs, BigInteger id ) throws NamingException;
         
-    /**
-     * TODO Document me!
-     *
-     * @param id TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listReverseIndices( BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listIndices() throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listIndices( Object attrVal ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param isGreaterThan TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listIndices( Object attrVal, boolean isGreaterThan )
         throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param regex TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listIndices( RE regex ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param regex TODO
-     * @param prefix TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     IndexEnumeration listIndices( RE regex, String prefix )
         throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param id TODO
-     * @return  TODO
-     * @throws NamingException TODO
-     */
     boolean hasValue( Object attrVal, BigInteger id ) 
         throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param attrVal TODO
-     * @param id TODO
-     * @param isGreaterThan TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     boolean hasValue( Object attrVal, BigInteger id, boolean isGreaterThan )
         throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @param regex TODO
-     * @param id TODO
-     * @return TODO
-     * @throws NamingException TODO
-     */
     boolean hasValue( RE regex, BigInteger id ) throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @throws NamingException TODO
-     */
     void close() throws NamingException;
 
-    /**
-     * TODO Document me!
-     *
-     * @throws NamingException TODO
-     */
     void sync() throws NamingException;
 }

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexAssertionEnumeration.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexAssertionEnumeration.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexAssertionEnumeration.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexAssertionEnumeration.java
Fri Jun 24 04:31:57 2005
@@ -56,13 +56,6 @@
     // ------------------------------------------------------------------------
 
 
-    /**
-     * TODO Domument me!
-     *
-     * @param underlying TODO
-     * @param assertion TODO
-     * @throws NamingException TODO
-     */
     public IndexAssertionEnumeration( NamingEnumeration underlying, 
         IndexAssertion assertion ) throws NamingException
     {
@@ -74,14 +67,6 @@
     }
 
 
-    /**
-     * TODO Domument me!
-     *
-     * @param underlying TODO
-     * @param assertion TODO
-     * @param enableDupCheck TODO
-     * @throws NamingException TODO
-     */
     public IndexAssertionEnumeration( NamingEnumeration underlying,
         IndexAssertion assertion, boolean enableDupCheck )
         throws NamingException
@@ -164,11 +149,6 @@
     // ------------------------------------------------------------------------
 
 
-    /**
-     * TODO Document me!
-     *
-     * @throws NamingException TODO
-     */
     private void prefetch() throws NamingException
     {
         IndexRecord rec = null;

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexEnumeration.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexEnumeration.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexEnumeration.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/IndexEnumeration.java
Fri Jun 24 04:31:57 2005
@@ -56,25 +56,12 @@
     // ------------------------------------------------------------------------
 
 
-    /**
-     * TODO Domument me!
-     *
-     * @param list TODO
-     * @throws NamingException TODO
-     */
     public IndexEnumeration( NamingEnumeration list ) throws NamingException
     {
         this( list, false, null );
     }
 
 
-    /**
-     * TODO Domument me!
-     *
-     * @param list TODO
-     * @param swapKeyVal TODO
-     * @throws NamingException TODO
-     */
     public IndexEnumeration( NamingEnumeration list, boolean swapKeyVal )
         throws NamingException
     {
@@ -82,14 +69,6 @@
     }
 
 
-    /**
-     * TODO Domument me!
-     *
-     * @param list TODO
-     * @param swapKeyVal TODO
-     * @param regex TODO
-     * @throws NamingException TODO
-     */
     public IndexEnumeration( NamingEnumeration list, boolean swapKeyVal,
                              RE regex )
         throws NamingException
@@ -174,11 +153,6 @@
     // ------------------------------------------------------------------------
 
 
-    /**
-     * TODO Document me!
-     *
-     * @throws NamingException TODO
-     */
     private void prefetch() throws NamingException
     {
         while ( underlying.hasMore() ) 

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/KeyOnlyComparator.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/KeyOnlyComparator.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/KeyOnlyComparator.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/KeyOnlyComparator.java
Fri Jun 24 04:31:57 2005
@@ -33,15 +33,9 @@
 {
     private static final long serialVersionUID = 3544956549803161397L;
 
-    /** TODO */
     private SerializableComparator keyComparator = null;
 
 
-    /**
-     * TODO Document me! 
-     *
-     * @param comparator  TODO
-     */
     public KeyOnlyComparator( SerializableComparator comparator )
     {
         keyComparator = comparator;
@@ -62,9 +56,6 @@
 
     /**
      * Will throw an UnsupportedOperationException every time.
-     *
-     * @return TODO
-     * @throws UnsupportedOperationException every time.
      */
     public SerializableComparator getValueComparator()
     {

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/NoDupsEnumeration.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/NoDupsEnumeration.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/NoDupsEnumeration.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/NoDupsEnumeration.java
Fri Jun 24 04:31:57 2005
@@ -57,10 +57,6 @@
 
     /**
      * Creates a cursor over a TupleBrowser where duplicates are not expected.
-     *
-     * @param browser TODO
-     * @param doAscendingScan TODO
-     * @throws NamingException TODO
      */
     public NoDupsEnumeration( TupleBrowser browser, boolean doAscendingScan )
         throws NamingException

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Table.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Table.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Table.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/Table.java
Fri Jun 24 04:31:57 2005
@@ -182,7 +182,6 @@
      *
      * @param key the key to use for the values
      * @param values the values supplied as an enumeration
-     * @return TODO
      * @throws NamingException if something goes wrong
      */
     Object put( Object key, NamingEnumeration values ) throws NamingException;
@@ -191,7 +190,6 @@
      * Removes all records with key from this Table.
      *
      * @param key the key of the records to remove
-     * @return TODO
      * @throws NamingException if there is a failure to read or write to
      * the underlying Db
      */
@@ -202,7 +200,6 @@
      *
      * @param key the key of the record to remove
      * @param value the value of the record to remove
-     * @return TODO
      * @throws NamingException if there is a failure to read or write to
      * the underlying Db
      */
@@ -219,8 +216,6 @@
      * duplicates.
      *
      * @param key the key of the records to remove
-     * @param values TODO
-     * @return TODO
      * @throws NamingException if there is a failure to read or write to
      * the underlying Db
      */
@@ -237,7 +232,6 @@
      * of the key.
      * 
      * @param key the key to iterate over
-     * @return TODO
      * @throws NamingException if the underlying browser could not be set
      */
     NamingEnumeration listValues( Object key ) throws NamingException;
@@ -252,7 +246,6 @@
      * Sets a cursor to the first record in the Table and enables single
      * next steps across all records.
      *
-     * @return TODO
      * @throws NamingException if the underlying cursor could not be set.
      */
     NamingEnumeration listTuples() throws NamingException;
@@ -263,7 +256,6 @@
      * this key.  This cursor will only iterate over duplicates of the key.
      *
      * @param key the key to iterate over
-     * @return TODO
      * @throws NamingException if the underlying cursor could not be set
      */
     NamingEnumeration listTuples( Object key ) throws NamingException;
@@ -278,7 +270,6 @@
      * @param isGreaterThan if true the cursor iterates up over ascending keys
      * greater than or equal to the key argument, but if false this cursor
      * iterates down over descending keys less than or equal to key argument
-     * @return TODO
      * @throws NamingException if the underlying cursor could not be set
      */
     NamingEnumeration listTuples( Object key, boolean isGreaterThan )
@@ -299,7 +290,6 @@
      * values greater than or equal to the val argument, but if false this 
      * cursor iterates down over descending values less than or equal to val 
      * argument starting from the largest value going down
-     * @return TODO
      * @throws NamingException if the underlying cursor could not be set or
      * this method is called over a cursor on a table that does not have sorted
      * duplicates enabled.

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/TupleEnumeration.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/TupleEnumeration.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/TupleEnumeration.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/TupleEnumeration.java
Fri Jun 24 04:31:57 2005
@@ -37,11 +37,8 @@
 public class TupleEnumeration
     implements NamingEnumeration
 {
-    /** TODO */
     private final Object key;
-    /** TODO */
     private final Iterator iterator;
-    /** TODO */
     private final Tuple tuple = new Tuple();
 
 

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/jdbm/JdbmIndex.java
URL: http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/jdbm/JdbmIndex.java?rev=201594&r1=201593&r2=201594&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/jdbm/JdbmIndex.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/partition/impl/btree/jdbm/JdbmIndex.java
Fri Jun 24 04:31:57 2005
@@ -92,13 +92,6 @@
     }
     
 
-    /**
-     * TODO Document me!
-     *
-     * @param attribute TODO
-     * @param wkDirPath TODO
-     * @throws NamingException TODO
-     */
     public JdbmIndex( AttributeType attribute, File wkDirPath )
         throws NamingException
     {
@@ -507,14 +500,8 @@
 
 
     /**
-     * TODO Document me!
-     * 
-     * @todo I don't think the keyCache is required anymore since the normalizer
+     * TODO I don't think the keyCache is required anymore since the normalizer
      * will cache values for us.
-     *
-     * @param attrVal TODO
-     * @return TODO
-     * @throws NamingException TODO
      */
     public Object getNormalized( Object attrVal )
         throws NamingException



Mime
View raw message