Return-Path: 
 <commits-return-4115-apmail-directory-commits-archive=directory.apache.org@directory.apache.org>
Delivered-To: apmail-directory-commits-archive@www.apache.org
Received: (qmail 88566 invoked from network); 25 Mar 2005 20:14:09 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 25 Mar 2005 20:14:09 -0000
Received: (qmail 75735 invoked by uid 500); 25 Mar 2005 20:13:42 -0000
Delivered-To: apmail-directory-commits-archive@directory.apache.org
Received: (qmail 75647 invoked by uid 500); 25 Mar 2005 20:13:41 -0000
Mailing-List: contact commits-help@directory.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@directory.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@directory.apache.org>
List-Post: <mailto:commits@directory.apache.org>
List-Id: <commits.directory.apache.org>
Reply-To: dev@directory.apache.org
Delivered-To: mailing list commits@directory.apache.org
Received: (qmail 75610 invoked by uid 99); 25 Mar 2005 20:13:41 -0000
X-ASF-Spam-Status: No, hits=-9.8 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from minotaur.apache.org (HELO minotaur.apache.org)
 (209.237.227.194)
  by apache.org (qpsmtpd/0.28) with SMTP; Fri, 25 Mar 2005 12:13:40 -0800
Received: (qmail 88401 invoked by uid 65534); 25 Mar 2005 20:13:39 -0000
Message-ID: <20050325201339.88400.qmail@minotaur.apache.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Mailer: svnmailer-1.0.0-dev
Date: Fri, 25 Mar 2005 20:13:39 -0000
Subject: svn commit: r159055 - in
 directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search:
 AndRule.java OrRule.java
To: commits@directory.apache.org
From: akarasulu@apache.org
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Author: akarasulu
Date: Fri Mar 25 12:13:37 2005
New Revision: 159055

URL: http://svn.apache.org/viewcvs?view=3Drev&rev=3D159055
Log:
dang sorry gotta roll out this patch it breaks a bunch of test cases

Modified:
    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/AndRule.java
    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/OrRule.java

Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/l=
dap/common/berlib/asn1/decoder/search/AndRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provi=
der/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java=
?view=3Ddiff&r1=3D159054&r2=3D159055
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/AndRule.java (original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/AndRule.java Fri Mar 25 12:13:37 2005
@@ -138,8 +138,7 @@
=20
             while( getDigester().peek() instanceof ExprNode )
             {
-                // TODO correct obvious performance hit here if this code =
stays around.
-                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
+                node.addNode( ( ExprNode ) getDigester().pop() );
             }
=20
             if ( getDigester().peek() =3D=3D this )
@@ -154,6 +153,10 @@
=20
                 throw new IllegalStateException( msg );
             }
+
+            StringBuffer strbuf =3D new StringBuffer( );
+
+            node.printToBuffer( strbuf );
=20
             getDigester().push( node );
         }

Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/l=
dap/common/berlib/asn1/decoder/search/OrRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provi=
der/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java?=
view=3Ddiff&r1=3D159054&r2=3D159055
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/OrRule.java (original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/co=
mmon/berlib/asn1/decoder/search/OrRule.java Fri Mar 25 12:13:37 2005
@@ -140,8 +140,7 @@
=20
             while( getDigester().peek() instanceof ExprNode )
             {
-                // TODO correct obvious performance hit here if this code =
stays around.
-                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
+                node.addNode( ( ExprNode ) getDigester().pop() );
             }
=20
             if ( getDigester().peek() =3D=3D this )
@@ -156,6 +155,10 @@
=20
                 throw new IllegalStateException( msg );
             }
+
+            StringBuffer strbuf =3D new StringBuffer( );
+
+            node.printToBuffer( strbuf );
=20
             getDigester().push( node );
         }