directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: r159053 - in directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search: AndRule.java OrRule.java
Date Fri, 25 Mar 2005 19:55:56 GMT
Author: akarasulu
Date: Fri Mar 25 11:55:54 2005
New Revision: 159053

URL: http://svn.apache.org/viewcvs?view=rev&rev=159053
Log:
applying 2nd patch from Jacob here http://issues.apache.org/jira/browse/DIRLDAP-38

Modified:
    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java

Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java?view=diff&r1=159052&r2=159053
==============================================================================
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
(original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
Fri Mar 25 11:55:54 2005
@@ -138,7 +138,8 @@
 
             while( getDigester().peek() instanceof ExprNode )
             {
-                node.addNode( ( ExprNode ) getDigester().pop() );
+                // TODO correct obvious performance hit here if this code stays around.
+                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
             }
 
             if ( getDigester().peek() == this )
@@ -153,10 +154,6 @@
 
                 throw new IllegalStateException( msg );
             }
-
-            StringBuffer strbuf = new StringBuffer( );
-
-            node.printToBuffer( strbuf );
 
             getDigester().push( node );
         }

Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java?view=diff&r1=159052&r2=159053
==============================================================================
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
(original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
Fri Mar 25 11:55:54 2005
@@ -140,7 +140,8 @@
 
             while( getDigester().peek() instanceof ExprNode )
             {
-                node.addNode( ( ExprNode ) getDigester().pop() );
+                // TODO correct obvious performance hit here if this code stays around.
+                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
             }
 
             if ( getDigester().peek() == this )
@@ -155,10 +156,6 @@
 
                 throw new IllegalStateException( msg );
             }
-
-            StringBuffer strbuf = new StringBuffer( );
-
-            node.printToBuffer( strbuf );
 
             getDigester().push( node );
         }



Mime
View raw message