directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: rev 20684 - incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message
Date Mon, 31 May 2004 05:59:34 GMT
Author: akarasulu
Date: Sun May 30 22:59:34 2004
New Revision: 20684

Modified:
   incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntry.java
   incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntryImpl.java
Log:
For some reason the SearchResponseEntry which corresponds to an LDAP 
SearchResultEntry was a subinterface of ResultResponse which it is not.
SearchResultEntry does not contain an LDAPResult according to 2251 but had one 
set.  Luckily it went unnoticed and no code in our base used it so we 
have corrected this flaw.



Modified: incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntry.java
==============================================================================
--- incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntry.java
(original)
+++ incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntry.java
Sun May 30 22:59:34 2004
@@ -202,61 +202,60 @@
  *   limitations under the License.
  *
  */
-
-/*
- * $Id: SearchResponseEntry.java,v 1.5 2003/08/21 20:44:32 jmachols Exp $
- *
- * -- (c) LDAPd Group                                                    --
- * -- Please refer to the LICENSE.txt file in the root directory of      --
- * -- any LDAPd project for copyright and distribution information.      --
- *
- */
-
-package org.apache.ldap.common.message ;
-
-
-import javax.naming.directory.Attributes ;
-
-
-/**
- * Search entry protocol response message used to return non referral entries
- * to the client in response to a search request message.
- *
- * @author <a href="mailto:aok123@bellsouth.net">Alex Karasulu</a>
- * @author $Author: jmachols $
- * @version $Revision: 1.5 $
- */
-public interface SearchResponseEntry
-    extends ResultResponse
-{
-    /** Search entry response message type enumeration value */
-    MessageTypeEnum TYPE = MessageTypeEnum.SEARCHRESENTRY ;
-
-    /**
-     * Gets the distinguished name of the entry object returned.
-     *
-     * @return the Dn of the entry returned.
-     */
-    String getObjectName() ;
-
-    /**
-     * Sets the distinguished name of the entry object returned.
-     *
-     * @param a_dn the Dn of the entry returned.
-     */
-    void setObjectName( String a_dn ) ;
-
-    /**
-     * Gets the set of attributes and all their values in a MultiMap.
-     *
-     * @return the set of attributes and all their values
-     */
-    Attributes getAttributes() ;
-
-    /**
-     * Sets the set of attributes and all their values in a MultiMap.
-     *
-     * @param a_attributes the set of attributes and all their values
-     */
-    void setAttributes( Attributes a_attributes ) ;
-}
+
+/*
+ * $Id: SearchResponseEntry.java,v 1.5 2003/08/21 20:44:32 jmachols Exp $
+ *
+ * -- (c) LDAPd Group                                                    --
+ * -- Please refer to the LICENSE.txt file in the root directory of      --
+ * -- any LDAPd project for copyright and distribution information.      --
+ *
+ */
+
+package org.apache.ldap.common.message ;
+
+
+import javax.naming.directory.Attributes ;
+
+
+/**
+ * Search entry protocol response message used to return non referral entries
+ * to the client in response to a search request message.
+ *
+ * @author <a href="mailto:aok123@bellsouth.net">Alex Karasulu</a>
+ * @author $Author: jmachols $
+ * @version $Revision: 1.5 $
+ */
+public interface SearchResponseEntry extends Response
+{
+    /** Search entry response message type enumeration value */
+    MessageTypeEnum TYPE = MessageTypeEnum.SEARCHRESENTRY ;
+
+    /**
+     * Gets the distinguished name of the entry object returned.
+     *
+     * @return the Dn of the entry returned.
+     */
+    String getObjectName() ;
+
+    /**
+     * Sets the distinguished name of the entry object returned.
+     *
+     * @param a_dn the Dn of the entry returned.
+     */
+    void setObjectName( String a_dn ) ;
+
+    /**
+     * Gets the set of attributes and all their values in a MultiMap.
+     *
+     * @return the set of attributes and all their values
+     */
+    Attributes getAttributes() ;
+
+    /**
+     * Sets the set of attributes and all their values in a MultiMap.
+     *
+     * @param a_attributes the set of attributes and all their values
+     */
+    void setAttributes( Attributes a_attributes ) ;
+}

Modified: incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntryImpl.java
==============================================================================
--- incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntryImpl.java
(original)
+++ incubator/directory/ldap/trunk/common/src/java/org/apache/ldap/common/message/SearchResponseEntryImpl.java
Sun May 30 22:59:34 2004
@@ -23,12 +23,12 @@
 /**
  * Lockable SearchResponseEntry implementation
  * 
- * @author <a href="mailto:directory-dev@incubator.apache.org">
- * Apache Directory Project</a>
- * @version $Rev$
+ * @author <a href="mailto:directory-dev@incubator.apache.org">
+ * Apache Directory Project</a>
+ * @version $Rev$
  */
 public class SearchResponseEntryImpl
-    extends AbstractResultResponse implements SearchResponseEntry
+    extends AbstractResponse implements SearchResponseEntry
 {
     /** Distinguished name of the search result entry returned */
     private String m_dn ;

Mime
View raw message