directory-api mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel L├ęcharny <elecha...@gmail.com>
Subject Re: API changes impact on ApacheDS, take 3
Date Sun, 15 May 2016 07:50:32 GMT
Progress !

I have all the tests in xdbm working but one (a failure on assertEquals(
0, rdn6.compareTo( rdn7 ) ); where rdn6 ->
ParentIdAndRdn<00000000-0000-0000-0000-000000000002,
'cn=test+sn=small'>[nbC:0, nbD:0] and rdn7 ->
ParentIdAndRdn<00000000-0000-0000-0000-000000000002, '2.5.4.4= Small +
2.5.4.3 = TEST '>[nbC:0, nbD:0], so basically it's a bug in the RDN
compareTo method).

This is critical because xdbm is the core for all the partitions, and
this is where we leverage the underlaying database. This module's tests
are usingthe AvlPartition, which is not impacted at all by any changes
made in the API. I'm confident that this is the key to get the server
working with the new API.

I still have some changes to do. Typically, we are comparing a
normalized key with a key that has to be normalized. The normalized key
is provided by the upper layer (the requested) and the other key comes
from the index. Now, when we add a tuple in the index, we always provide
a normalized key, so we also store this normalized key. At this point,
it makes no sense to re-normalize something that is already normalized
(it's a costly operation that involves a String preparation phase). I
think we can spare us this kind of costly operation. I'll fix that when
I'll have all the tests fixed.



Mime
View raw message