Mailing-List: contact api-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: api@directory.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <54F94E19.8020301@evolveum.com>
Date: Fri, 06 Mar 2015 07:50:01 +0100
From: Radovan Semancik <radovan.semancik@evolveum.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: api@directory.apache.org
Subject: Re: isHumanReadable in LdapSyntax
References: <54F7301F.1060108@evolveum.com> <54F85F2D.3080200@gmail.com>
 <54F87703.9010502@evolveum.com> <54F8816F.5030609@gmail.com>
 <54F887AA.8050506@evolveum.com> <54F88FCF.8010109@gmail.com>
 <54F894C9.5060404@evolveum.com> <54F89BA3.8090802@gmail.com>
In-Reply-To: <54F89BA3.8090802@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for comments. I'll have a look at the  *Tags enums. But I guess=20
it will be a bit inconvenient for me to work on my github fork and you=20
working on svn trunk ...

I would suggest this: let me finish my rudimentary implementation. Now I=20
have to speed things up a bit, so it probably won't take longer than a=20
week or two. I'm using VLV and schema in my LDAP connector for midPoint.=20
I'm also working on automated tests that will use=20
midPoint+connector+directory API with OpenLDAP and 389ds (I already have=20
tests for OpenDJ). Once I have that then I will create a pull request so=20
it can get to the directory API project trunk. The code will probably be=20
a bit ugly ... but once it is in trunk you are free to clean it up. And=20
as I will have the tests I can check that it still works after your=20
cleanup ...

I was thinking about how to make unit tests for this directly in the=20
directory API project. Simple tests for VLV controls parse and encode=20
will be probably a good idea. But this is not really enough to make sure=20
that the whole thing really works. Do you have any kind of test suite=20
for directory API that is using real LDAP servers?

--=20

                                            Radovan Semancik
                                           Software Architect
                                              evolveum.com


On 03/05/2015 07:08 PM, Emmanuel L=C3=A9charny wrote:
> We declare the tags in a XXXTags file, like in :
>
> public enum PasswordPolicyTags
> {
>      PPOLICY_WARNING_TAG(0xA0), // warning [0]
>      PPOLICY_ERROR_TAG(0x81), // error [1]
>      TIME_BEFORE_EXPIRATION_TAG(0x80), // timeBeforeExpiration [0]
>      GRACE_AUTHNS_REMAINING_TAG(0x81); // graceAuthNsRemaining [1]
>      ...
>
> One thing that is missing is the choice between byteOffset and an
> assertionValue : we should have a flag in the impl to determinate which
> of the two is in use.
>
> the contextID might be empty, and might be absent from the PDU. Those
> are 2 different use cases. We should cover both.
>
>
> The VLV control will probably be put into the codec-extras module.
>
> I'll check that tonite !
>
>
>