Mailing-List: contact api-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: api@directory.apache.org
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.160.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=I4fbm0H8+Dap2+lR3VPPVQ4wW0iaX8jooaMT3Hgp3iEnJMBcRHEt/bnd4zpHXJlt1q
         Pn32+i/niFyAPTZXJkx6AhfE8h+rUs8PEkDFLi8TDlHUlYBiQQDcg9JkRZg3Y0UKTZEU
         f1fMxlxPpdQSj0HQTb2bmTuVq/e55p7Z6flyA=
Message-ID: <4C595824.9050202@gmail.com>
Date: Wed, 04 Aug 2010 14:08:04 +0200
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1
MIME-Version: 1.0
To: api@directory.apache.org
Subject: Re: removing unused methods from DN class
References: <AANLkTikXQARR_npaTdZJLR-VtyMjPoc6uJ0nkhi-V4eF@mail.gmail.com>
In-Reply-To: <AANLkTikXQARR_npaTdZJLR-VtyMjPoc6uJ0nkhi-V4eF@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

  On 8/4/10 12:04 PM, Kiran Ayyagari wrote:
> hello guys,
>
>          When I was working on making DN immutable have come across
> some of the methods which are not used anywhere in the server code
>
> 1. DN addAll( int posn, Name name ) - except at two places in DNTest
> class, which we can remove
This method was created to offer some kind of JNDI conversion tools. I 
think it's useless, as such a JNDI <-> API tool may use a dedicated class.
> 2. DN add( int pos, RDN newRdn ) - there is another method to add RDN
You are right, it's useless.
> 3. DN addNormalized( RDN newRdn ) - this functionality is already
> present in another method add(RDN)
+1 too. Doom it.
> and the serialization functions
> 1. void readExternal( ObjectInput in )
> 2. void writeExternal( ObjectOutput out )
>
> this serialization functionality has been moved to DnSerializer class
Doom them.
> I propose that we get rid of these methods, thoughts?
No thoughts. Action !

-- 
Regards,
Cordialement,
Emmanuel L�charny
www.iktek.com