directory-api mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: removing unused methods from DN class
Date Wed, 04 Aug 2010 12:08:04 GMT
  On 8/4/10 12:04 PM, Kiran Ayyagari wrote:
> hello guys,
>
>          When I was working on making DN immutable have come across
> some of the methods which are not used anywhere in the server code
>
> 1. DN addAll( int posn, Name name ) - except at two places in DNTest
> class, which we can remove
This method was created to offer some kind of JNDI conversion tools. I 
think it's useless, as such a JNDI <-> API tool may use a dedicated class.
> 2. DN add( int pos, RDN newRdn ) - there is another method to add RDN
You are right, it's useless.
> 3. DN addNormalized( RDN newRdn ) - this functionality is already
> present in another method add(RDN)
+1 too. Doom it.
> and the serialization functions
> 1. void readExternal( ObjectInput in )
> 2. void writeExternal( ObjectOutput out )
>
> this serialization functionality has been moved to DnSerializer class
Doom them.
> I propose that we get rid of these methods, thoughts?
No thoughts. Action !

-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.iktek.com


Mime
View raw message