directmemory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raffaele P. Guidi" <raffaele.p.gu...@gmail.com>
Subject Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution
Date Sun, 30 Sep 2012 13:47:22 GMT
We were talking about separating the contribution in two pieces: lightning
itself as a subproject under the directmemory/lightning folder and then the
serializer module for directmemory in the serialization folder.

Agreed to the coding style consideration (I forgot about it) and -regarding
the ignore annotation - I found many of them in the main package, I think
the point is that they have been moved to another module (more appropriate)
and never deleted.

Ciao,
    R
Il giorno 30/set/2012 15:05, "Simone Tripodi (JIRA)" <jira@apache.org> ha
scritto:

>
>     [
> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>
> Simone Tripodi commented on DIRECTMEMORY-102:
> ---------------------------------------------
>
> Hi Christoph,
>
> thanks for contributing! Patch looks quiet good, I'd followup the
> discussion on the dev@ ML first, I have some observations about the
> inclusion before applying it. I am going to send a message following up the
> current thread in a short while.
> Thanks *a lot* for the hard work and congrats for that lib!
>
> In the case you are looking for some feedbacks, follow below few (ASF
> general) suggestions to submit patches:
>
> _Higher priority_
>
>  * serializer modules are put under the [serializers|
> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
> directory;
>
>  * no tabs; 2 spaces for XML sources, 4 spaces for Java sources -
> generally, please respect the original source code format, people here if
> following the Apache Maven [code conventions|
> http://maven.apache.org/developers/conventions/code.html] (IDEs config
> included);
>
>  * According to other serializer modules, the package should be moved to
> {{org.apache.directmemory.serialization.lightning}};
>
>  * No needs to define and implement yet another logging abstraction
> level/fa├žade:
>
>  * No needs to define a {{Marshaller}}/{{Unmarshaller}}, the reference
> interface can be directly the
> [org.apache.directmemory.serialization.Serializer|
> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
> class;
>
> _Lower priority_
>
>  * please name patch file with the issue key, i.e.
> {{DIRECTMEMORY-102.patch}}, it helps committers that are reviewing and
> applying patches;
>
>  * In the following code:
>
> {code}
> +@SuppressWarnings("serial")
> +public class ClassDefinitionInconsistentException extends
> RuntimeException {
> {code}
>
>   you don't need to suppress the serial, you can add serialVersionUID
> field;
>
>  * same for {{IllegalAccessorException}};
>
>  * same for {{IllegalPropertyAccessException}};
>
>  * same for {{SerializerDefinitionException}};
>
>  * same for {{SerializerExecutionException}};
>
>  * same for {{SerializerMarshallerGeneratorException}};
>
>  * Please drop {{@author}} tags, feel free to add yourself in the
> {{contributors}} section in the parent POM - this is the right place where
> people are enlisted;
>
>  * no needs to define a {{StringUtil}} class unless [Guava|
> http://code.google.com/p/guava-libraries/wiki/StringsExplained] doesn't
> provide the functionalities you need; the DirectMemory core module relies
> on Guava;
>
>  * same for {{TypeUtil}}
>
>  * why {{Benchmark}} class is annotated with {{@Ignore}}?
>
> > Lightning Serializer Contribution
> > ---------------------------------
> >
> >                 Key: DIRECTMEMORY-102
> >                 URL:
> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
> >             Project: Apache DirectMemory
> >          Issue Type: New Feature
> >          Components: Serializers
> >            Reporter: Christoph Engelbert
> >         Attachments: lightning_contribution.patch
> >
> >
> > This is the first contribution patch attempt for the lightning
> serializer. If there are any things need to be changed please let me know.
> > PS: The issue tracker and sourcelocation values in the pom.xml aren't
> set yet, since I had no clue what are the correct values but I guess that
> could be set later on.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message