devicemap-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Volkan Yazıcı <volkan.yaz...@gmail.com>
Subject Re: Uncommitted patch DMAP-107
Date Mon, 13 Jul 2015 16:19:50 GMT
Because, IIRC, they were failing due to ordering issues at the DDR files,
which should not happen in the first hand. (I believe it was due to the
same reason that tests were failing with Java 8.) I will try it out in the
weekend and see what happens. Will keep the list posted.

On Mon, Jul 13, 2015 at 4:53 PM, Reza Naghibi <reza@naghibi.com> wrote:

> This sounds good. Why does the patch remove 2 user agents from the test
> file?
>
> On Mon, Jul 13, 2015 at 6:06 AM, Volkan Yazıcı <volkan.yazici@gmail.com>
> wrote:
>
> > Then if there are no objects, I will proceed patching 1.x this week.
> >
> > On Mon, Jul 13, 2015 at 11:59 AM, Werner Keil <werner.keil@gmail.com>
> > wrote:
> >
> > > If it improves the performance, as Stefan mentioned, I see no reason
> why
> > > you should wait.
> > > 2.x is very likely to be much different, most importantly using JSON,
> so
> > > the patch could not even match there as it does now;-)
> > >
> > > Cheers,
> > > Werner
> > >
> > > On Mon, Jul 13, 2015 at 11:39 AM, Volkan Yazıcı <
> volkan.yazici@gmail.com
> > >
> > > wrote:
> > >
> > > > Hello Reza,
> > > >
> > > > I was waiting for the 2.0 release of the client to commit those
> > changes.
> > > Do
> > > > you want me to commit them to the 1.x branch?
> > > >
> > > > Best.
> > > >
> > > > On Fri, Jul 10, 2015 at 9:40 PM, Reza Naghibi <rezan@apache.org>
> > wrote:
> > > >
> > > > > No reason. This patch was submitted by Volkan before he had commit
> > > > rights,
> > > > > so he posted it on JIRA. Volkan is now a committer and he is
> allowed
> > to
> > > > > work on the 1.0 clients, so im pretty sure he is free to commit the
> > > > patch.
> > > > >
> > > > > On Fri, Jul 10, 2015 at 3:15 PM, Stefan Seelmann <
> > > > mail@stefan-seelmann.de>
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I browsed through the devicemap-client Java code and saw some
> > > > > > performance optimizations in DeviceMapClient.classify(). Then
I
> saw
> > > > that
> > > > > > there is already an issue and patch available since last
> December.
> > Is
> > > > > > there a reason why it is not yet committed? The patch currently
> > has a
> > > > > > compile error as commons-lang is not in dependencies but that's
> > easy
> > > to
> > > > > > fix.
> > > > > >
> > > > > > Kind Regards,
> > > > > > Stefan
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/DMAP-107
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message