Return-Path: X-Original-To: apmail-devicemap-dev-archive@www.apache.org Delivered-To: apmail-devicemap-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5979C10366 for ; Fri, 2 Jan 2015 05:49:25 +0000 (UTC) Received: (qmail 60922 invoked by uid 500); 2 Jan 2015 05:49:26 -0000 Delivered-To: apmail-devicemap-dev-archive@devicemap.apache.org Received: (qmail 60884 invoked by uid 500); 2 Jan 2015 05:49:26 -0000 Mailing-List: contact dev-help@devicemap.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@devicemap.apache.org Delivered-To: mailing list dev@devicemap.apache.org Received: (qmail 60822 invoked by uid 99); 2 Jan 2015 05:49:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2015 05:49:23 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of werner.keil@gmail.com designates 209.85.218.53 as permitted sender) Received: from [209.85.218.53] (HELO mail-oi0-f53.google.com) (209.85.218.53) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2015 05:49:18 +0000 Received: by mail-oi0-f53.google.com with SMTP id g201so39654500oib.12 for ; Thu, 01 Jan 2015 21:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=AeZgCJjPk3gf2FeBM2nEVBgtkjA51dgbMaYhAY7k8d8=; b=yMY2gB263wRn76WbNmiZz+Hn1nBAZNpYyVfIi02MeBrvoMzEz/LFIyRTAW3+82xlCu 3e5k19JzyWM1Namk9JagZwlB8Nf0bufdMBKwnV7LQURaY2WLYDYRFY9DQdgz/XufwIW/ 57meeLkHLJPVOBItlcO3R4MWoSqsC9jcoIic59zd7QLnUv+e4t/X5qH2SpBfPRWgbka6 Pm/aNhpJc6D9E+DJcBGouKeruEQNs5aB6eMizt4W6UvyEp2cCmjEu0d7BDhhmyQ9PyBc fWb9qz1qlGrb9UQ6cE5wBKS/zdM0Ls2dPuIcPRwslDu+9NobGJB1cr9soWTyBk67eFfA wxug== MIME-Version: 1.0 X-Received: by 10.182.71.73 with SMTP id s9mr44451782obu.15.1420177692627; Thu, 01 Jan 2015 21:48:12 -0800 (PST) Received: by 10.202.129.131 with HTTP; Thu, 1 Jan 2015 21:48:12 -0800 (PST) Date: Fri, 2 Jan 2015 06:48:12 +0100 Message-ID: Subject: Improper "aliasing" of devices From: Werner Keil To: dev@devicemap.apache.org Content-Type: multipart/alternative; boundary=e89a8fb1fa7ee3197b050ba4e29b X-Virus-Checked: Checked by ClamAV on apache.org --e89a8fb1fa7ee3197b050ba4e29b Content-Type: text/plain; charset=UTF-8 Reza/all, As of data 1.x the attempt of "aliasing" device data by trying to override a parent device with just a single incomplete line is not working and illegitimate. It breaks both clients. If such "simplified" device data modeling was desired, it has to be done for 2.x, as it breaks compatibility with the 1.x and W3C data model. After elliminating the wrong/incomplete line for "SGP312" remaining SGP311 is properly recognized. Based on Data 1.0.1 it seems the 2 new/wrong entries are ignored, in fact if below issue Tests run: 1176, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.67 sec <<< FAILURE! - in org.apache.devicemap.DeviceMapClientTest testDeviceMapClient[1174](org.apache.devicemap.DeviceMapClientTest) Time elapsed: 0 sec <<< FAILURE! org.junit.ComparisonFailure: classification failed for 'Mozilla/5.0 (Linux; Android 4.3; SGP311 Build/10.4.B.0.577) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.102 Safari/537.36' *expected:<[genericAndroid]> but was:<[SGP311]>* at org.junit.Assert.assertEquals(Assert.java:115) at org.apache.devicemap.DeviceMapClientTest.testDeviceMapClient(DeviceMapClientTest.java:74) is addressed using data 1.0.2-SNAPSHOT with the correct test data file for SGP311, the extra line SGP312 in the test file is safely ignored. Please if needed add a complete record, This fixes both https://issues.apache.org/jira/browse/DMAP-120 and https://issues.apache.org/jira/browse/DMAP-121 you bluntly and prematurely brushed away. Thanks, Werner --e89a8fb1fa7ee3197b050ba4e29b--