devicemap-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Werner Keil <werner.k...@gmail.com>
Subject Improper "aliasing" of devices
Date Fri, 02 Jan 2015 05:48:12 GMT
Reza/all,

As of data 1.x the attempt of "aliasing" device data by trying to override
a parent device with just a single incomplete line is not working and
illegitimate.

It breaks both clients.

If such "simplified" device data modeling was desired, it has to be done
for 2.x, as it breaks compatibility with the 1.x and W3C data model.

After elliminating the wrong/incomplete line for "SGP312" remaining SGP311
is properly recognized.

Based on Data 1.0.1 it seems the 2 new/wrong entries are ignored, in fact
if below issue

Tests run: 1176, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.67 sec
<<< FAILURE! - in org.apache.devicemap.DeviceMapClientTest
testDeviceMapClient[1174](org.apache.devicemap.DeviceMapClientTest)  Time
elapsed: 0 sec  <<< FAILURE!
org.junit.ComparisonFailure: classification failed for 'Mozilla/5.0 (Linux;
Android 4.3; SGP311 Build/10.4.B.0.577) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/38.0.2125.102 Safari/537.36' *expected:<[genericAndroid]> but
was:<[SGP311]>*
at org.junit.Assert.assertEquals(Assert.java:115)
at
org.apache.devicemap.DeviceMapClientTest.testDeviceMapClient(DeviceMapClientTest.java:74)

is addressed using data 1.0.2-SNAPSHOT with the correct test data file for
SGP311, the extra line SGP312 in the test file is safely ignored.

Please if needed add a complete record,

This fixes both https://issues.apache.org/jira/browse/DMAP-120 and
https://issues.apache.org/jira/browse/DMAP-121 you bluntly and prematurely
brushed away.

Thanks,
Werner

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message