devicemap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Volkan Yazıcı (JIRA) <j...@apache.org>
Subject [jira] [Commented] (DMAP-54) Improve Console example
Date Fri, 02 Jan 2015 09:39:13 GMT

    [ https://issues.apache.org/jira/browse/DMAP-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262810#comment-14262810
] 

Volkan Yazıcı commented on DMAP-54:
-----------------------------------

Thanks for the review [~rezan], below are my comments.

1) I had written my own CLI argument parsers for years due to many reasons (who else needs
another dependency, after all I just need a couple of lines of code, etc.) and as years pass
by I realize what an awful waste of time that was. I have been using JCommander for the last
two years pleasantly. It keeps my code clean, expressive and lessens the number of LoC that
needs maintenance. And it is 60KB in size and in the market since 2010. So, if you would allow,
I really would like to keep the current CLI argument parsing routines as is in the patch.

2) Fine, no problem.

[~rezan], if you are ok with (1), I will submit another patch.

> Improve Console example
> -----------------------
>
>                 Key: DMAP-54
>                 URL: https://issues.apache.org/jira/browse/DMAP-54
>             Project: DeviceMap
>          Issue Type: Task
>          Components: Java Client, Java Examples
>            Reporter: Werner Keil
>            Assignee: Werner Keil
>              Labels: console, example
>             Fix For: 1.0.0 Java Examples
>
>         Attachments: cmd.diff
>
>
> Pass UA parameter to override the default if provided



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message