devicemap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reza Naghibi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DMAP-54) Improve Console example
Date Wed, 31 Dec 2014 13:42:13 GMT

    [ https://issues.apache.org/jira/browse/DMAP-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262171#comment-14262171
] 

Reza Naghibi commented on DMAP-54:
----------------------------------

So some issues here:

1) We cannot bring in a new dependency just for the cmd line interface. The cmdline is mainly
used for testing and is not core to the API, so it does not justify bringing in a new dependency.

2) While we do not have style guides, I would recommend you do not use un-enclosed if statements.
Its always best to follow the style of the code you are patching.

> Improve Console example
> -----------------------
>
>                 Key: DMAP-54
>                 URL: https://issues.apache.org/jira/browse/DMAP-54
>             Project: DeviceMap
>          Issue Type: Task
>          Components: Java Client, Java Examples
>            Reporter: Werner Keil
>            Assignee: Werner Keil
>              Labels: console, example
>             Fix For: 1.0.0 Java Examples
>
>         Attachments: cmd.diff
>
>
> Pass UA parameter to override the default if provided



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message