Return-Path: 
 <deltaspike-dev-return-3542-apmail-incubator-deltaspike-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B7027DC55
	for <apmail-incubator-deltaspike-dev-archive@minotaur.apache.org>;
 Fri, 30 Nov 2012 10:16:02 +0000 (UTC)
Received: (qmail 21754 invoked by uid 500); 30 Nov 2012 10:16:02 -0000
Delivered-To: apmail-incubator-deltaspike-dev-archive@incubator.apache.org
Received: (qmail 21608 invoked by uid 500); 30 Nov 2012 10:16:02 -0000
Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:deltaspike-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:deltaspike-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:deltaspike-dev@incubator.apache.org>
List-Id: <deltaspike-dev.incubator.apache.org>
Reply-To: deltaspike-dev@incubator.apache.org
Delivered-To: mailing list deltaspike-dev@incubator.apache.org
Received: (qmail 21521 invoked by uid 99); 30 Nov 2012 10:16:00 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 10:16:00 +0000
Date: Fri, 30 Nov 2012 10:15:59 +0000 (UTC)
From: "Jozef Hartinger (JIRA)" <jira@apache.org>
To: deltaspike-dev@incubator.apache.org
Message-ID: <338192234.44669.1354270560033.JavaMail.jiratomcat@arcas>
In-Reply-To: <1903737792.40435.1354204139613.JavaMail.jiratomcat@arcas>
Subject: [jira] [Comment Edited] (DELTASPIKE-295) JsfMessageProducer
 createJsfMessage return type should be parametrized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DELTASPIKE-295?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13507240#comment-13507240 ]=20

Jozef Hartinger edited comment on DELTASPIKE-295 at 11/30/12 10:15 AM:
-----------------------------------------------------------------------

CDI 1.0 Section 5.2 Typesafe resolution says:

"Parameterized and raw types are considered to match if they are identical =
or if the bean type is assignable to
the required type, as defined in Section 5.2.3, =E2=80=9CAssignability of r=
aw and parameterized types"

The bean type is not identical to the required type nor are these types def=
ined as assignable  in 5.2.3

I hope introducing the type variable to the producer method won't break oth=
er containers as otherwise we have a problem.
               =20
      was (Author: jharting):
    CDI 1.0 Section 5.2 Typesafe resolution says:

{quote}Parameterized and raw types are considered to match if they are iden=
tical or if the bean type is assignable to
the required type, as defined in Section 5.2.3, =E2=80=9CAssignability of r=
aw and parameterized types=E2=80=9D{quote}

The bean type is not identical to the required type nor are these types def=
ined as assignable  in 5.2.3

I hope introducing the type variable to the producer method won't break oth=
er containers as otherwise we have a problem.
                 =20
> JsfMessageProducer createJsfMessage return type should be parametrized
> ----------------------------------------------------------------------
>
>                 Key: DELTASPIKE-295
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-295
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: JSF-Module
>    Affects Versions: 0.4-incubating
>         Environment: Current 0.4-incubating snapshot, Weld 2.0.0.Beta1
>            Reporter: Marek Schmidt
>             Fix For: 0.4-incubating
>
>
> The=20
> {code}
> public JsfMessage createJsfMessage(InjectionPoint injectionPoint)
> {code}
> should probably be
> {code}
> public <T> JsfMessage<T> createJsfMessage(InjectionPoint injectionPoint)
> {code}
> instead.
> The problem manifests itself in Weld 2.0.0.Beta1:
> {noformat}
> Tests in error:=20
>   org.apache.deltaspike.test.jsf.impl.message.JsfMessageTest: Could not d=
eploy to container: {"JBAS014671: Failed services" =3D> {"jboss.deployment.=
unit.\"jsfMessageTest.war\".WeldService" =3D> "org.jboss.msc.service.StartE=
xception in service jboss.deployment.unit.\"jsfMessageTest.war\".WeldServic=
e: org.jboss.weld.exceptions.DeploymentException: WELD-001408 Unsatisfied d=
ependencies for type [JsfMessage<UserMessage>] with qualifiers [@Default] a=
t injection point [[BackedAnnotatedField] @Inject private org.apache.deltas=
pike.test.jsf.impl.message.beans.JsfMessageBackingBean.msg]"}}
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira