Return-Path: 
 <deltaspike-dev-return-3547-apmail-incubator-deltaspike-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6C87EEBC5
	for <apmail-incubator-deltaspike-dev-archive@minotaur.apache.org>;
 Fri, 30 Nov 2012 13:18:00 +0000 (UTC)
Received: (qmail 4702 invoked by uid 500); 30 Nov 2012 13:18:00 -0000
Delivered-To: apmail-incubator-deltaspike-dev-archive@incubator.apache.org
Received: (qmail 4461 invoked by uid 500); 30 Nov 2012 13:17:59 -0000
Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:deltaspike-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:deltaspike-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:deltaspike-dev@incubator.apache.org>
List-Id: <deltaspike-dev.incubator.apache.org>
Reply-To: deltaspike-dev@incubator.apache.org
Delivered-To: mailing list deltaspike-dev@incubator.apache.org
Received: (qmail 4406 invoked by uid 99); 30 Nov 2012 13:17:58 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 13:17:58 +0000
Date: Fri, 30 Nov 2012 13:17:58 +0000 (UTC)
From: "Jozef Hartinger (JIRA)" <jira@apache.org>
To: deltaspike-dev@incubator.apache.org
Message-ID: <1327718602.45042.1354281478873.JavaMail.jiratomcat@arcas>
In-Reply-To: <1903737792.40435.1354204139613.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (DELTASPIKE-295) JsfMessageProducer
 createJsfMessage return type should be parametrized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DELTASPIKE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507315#comment-13507315 ] 

Jozef Hartinger commented on DELTASPIKE-295:
--------------------------------------------

> "The bean has a bean type that matches the required type."

The spec says that and then explains further what it means. For raw and parameterized types (our case) it means that either the two types are identical (not true in our case) or the bean type is assignable to the required type as defined in 5.2.3. 5.2.3 does not say that JmsMessage (a raw type) is assignable to JmsMessage<UserMessage> (parameterized type) so this part is also false in our case.

> Of course we CANNOT return JsfMessage<T> as this would probably also require InjectionPoint to be a parameterized InjectionPoint<T> type to support all use cases.

Which use cases would require InjectionPoint<T>?

                
> JsfMessageProducer createJsfMessage return type should be parametrized
> ----------------------------------------------------------------------
>
>                 Key: DELTASPIKE-295
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-295
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: JSF-Module
>    Affects Versions: 0.4-incubating
>         Environment: Current 0.4-incubating snapshot, Weld 2.0.0.Beta1
>            Reporter: Marek Schmidt
>             Fix For: 0.4-incubating
>
>
> The 
> {code}
> public JsfMessage createJsfMessage(InjectionPoint injectionPoint)
> {code}
> should probably be
> {code}
> public <T> JsfMessage<T> createJsfMessage(InjectionPoint injectionPoint)
> {code}
> instead.
> The problem manifests itself in Weld 2.0.0.Beta1:
> {noformat}
> Tests in error: 
>   org.apache.deltaspike.test.jsf.impl.message.JsfMessageTest: Could not deploy to container: {"JBAS014671: Failed services" => {"jboss.deployment.unit.\"jsfMessageTest.war\".WeldService" => "org.jboss.msc.service.StartException in service jboss.deployment.unit.\"jsfMessageTest.war\".WeldService: org.jboss.weld.exceptions.DeploymentException: WELD-001408 Unsatisfied dependencies for type [JsfMessage<UserMessage>] with qualifiers [@Default] at injection point [[BackedAnnotatedField] @Inject private org.apache.deltaspike.test.jsf.impl.message.beans.JsfMessageBackingBean.msg]"}}
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira