deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Porter <lightguard...@gmail.com>
Subject Re: Review for v0.3
Date Tue, 03 Jul 2012 20:48:27 GMT
I haven't gone through with a super fine comb, but things look okay to me
for a v0.3 release (of course deciding what to do with those classes above
needs to happen).

On Tue, Jul 3, 2012 at 1:36 PM, Gerhard Petracek <gerhard.petracek@gmail.com
> wrote:

> +1
>
> regards,
> gerhard
>
>
>
> 2012/7/3 Mark Struberg <struberg@yahoo.de>
>
> >
> >
> > MessageContext is really usable for dynamic string stuff. I'd let this in
> > the API.
> >
> > LieGrue,
> > strub
> >
> >
> >
> >
> > >________________________________
> > > From: Jason Porter <lightguard.jp@gmail.com>
> > >To: deltaspike-dev@incubator.apache.org; Mark Struberg <
> struberg@yahoo.de
> > >
> > >Sent: Tuesday, July 3, 2012 7:13 PM
> > >Subject: Re: Review for v0.3
> > >
> > >
> > >MessageContext I would think would also be a candidate, or maybe pull
> > parts of it out and put in the spi.
> > >
> > >
> > >On Tue, Jul 3, 2012 at 1:10 PM, Mark Struberg <struberg@yahoo.de>
> wrote:
> > >
> > >The MessageResolver is also a candidate.
> > >>
> > >>Those 3  are only referenced from a @MessageContextConfig or
> > MessageContext IF a user likes to render a message with a different
> > setting. I consider this a rare use case (existing, but rare). It's
> really
> > more often the case that a user likes to generally set his own
> > LocaleResolver as @Alternative where he evaluates the users language, the
> > JSF view language, etc.
> > >>
> > >>Thus +1 for moving it to SPI.
> > >>
> > >>LieGrue,
> > >>strub
> > >>
> > >>
> > >>
> > >>----- Original Message -----
> > >>> From: Jason Porter <lightguard.jp@gmail.com>
> > >>> To: deltaspike-dev@incubator.apache.org
> > >>> Cc:
> > >>> Sent: Tuesday, July 3, 2012 6:50 PM
> > >>> Subject: Review for v0.3
> > >>>
> > >>>T here may be more added to this list as we go through, but currently
> it
> > >>
> > >>> looks like MessageInterpolator and LocaleResolver should be moved to
> > the
> > >>> spi package. Please comment below.
> > >>>
> > >>> --
> > >>> Jason Porter
> > >>> http://lightguard-jp.blogspot.com
> > >>> http://twitter.com/lightguardjp
> > >>>
> > >>> Software Engineer
> > >>> Open Source Advocate
> > >>> Author of Seam Catch - Next Generation Java Exception Handling
> > >>>
> > >>> PGP key id: 926CCFF5
> > >>> PGP key available at: keyserver.net, pgp.mit.edu
> > >>>
> > >>
> > >
> > >
> > >
> > >--
> > >Jason Porter
> > >http://lightguard-jp.blogspot.com
> > >http://twitter.com/lightguardjp
> > >
> > >Software Engineer
> > >Open Source Advocate
> > >Author of Seam Catch - Next Generation Java Exception Handling
> > >
> > >PGP key id: 926CCFF5
> > >PGP key available at: keyserver.net, pgp.mit.edu
> > >
> > >
> > >
> >
>



-- 
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp

Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling

PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message