deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Porter <lightguard...@gmail.com>
Subject Re: [DISCUSS] drop the integration-test module?
Date Fri, 06 Jul 2012 16:18:25 GMT
Are you building on the CI servers or do you have all the containers
locally? I can take a look at JBoss AS.

On Fri, Jul 6, 2012 at 8:11 AM, Mark Struberg <struberg@yahoo.de> wrote:

> I've now got OWB, Weld and tomee running again. But I see quite a few
> errors on other containers. Resp there is still a lot to do for them.
>
> Should I continue in a branch, or is there any help in sight from others
> and I shall just push it in good faith that those get resolved?
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
> > From: Mark Struberg <struberg@yahoo.de>
> > To: "deltaspike-dev@incubator.apache.org" <
> deltaspike-dev@incubator.apache.org>
> > Cc:
> > Sent: Friday, July 6, 2012 10:57 AM
> > Subject: Re: [DISCUSS] drop the integration-test module?
> >
> >T he main difference of the failsafe-maven-plugin is that it doesn't abort
> > the build on errors. Thus you can cleanly shutdown the server after all
> tests
> > did run. There is actually not much difference regarding the phase as we
> already
> > configured the surefire plugin to run in the integration-test phase.
> >
> > LieGrue,
> > strub
> >
> >
> >
> > ----- Original Message -----
> >>  From: Christian Kaltepoth <christian@kaltepoth.de>
> >>  To: deltaspike-dev@incubator.apache.org
> >>  Cc: Mark Struberg <struberg@yahoo.de>
> >>  Sent: Friday, July 6, 2012 10:48 AM
> >>  Subject: Re: [DISCUSS] drop the integration-test module?
> >>
> >>  +1 for dropping it.
> >>
> >>  As I already mentioned some time ago, having two places for the tests
> >>  (tests in the integration-test module and test in the module itself)
> >>  is IMHO a bad idea. And I think it is easier to have the tests
> >>  directly in the modules.
> >>
> >>  Regarding the failsafe plugin: Would this bring us any advantage apart
> >>  from the fact that the integration tests would run in a different
> >>  Maven phase?
> >>
> >>  Christian
> >>
> >>  2012/7/6 Romain Manni-Bucau <rmannibucau@gmail.com>:
> >>>   if surefire is still used for weld or owb by default +1
> >>>
> >>>   - Romain
> >>>
> >>>
> >>>   2012/7/6 Mark Struberg <struberg@yahoo.de>
> >>>
> >>>>   and merge those profiles to the main impl modules?
> >>>>
> >>>>   Our integration tests are currently pretty hard to debug as we
> > unpack
> >>  the
> >>>>   test sources to the integration test module and then run the
> > tests.
> >>>>
> >>>>   It was originally planed that the core tests do always run with
> > Weld or
> >>>>   OWB and only the container specific tests will run again if an EE
> >>  container
> >>>>   got specified. But it turned out that this is a bit complicated to
> >
> >>  debug.
> >>>>
> >>>>
> >>>>
> >>>>   Thus I'm thinking about dropping the integration-test modules
> > and
> >>  move all
> >>>>   the profiles to parent/code/pom.xml
> >>>>
> >>>>   I also like to move the integration tests from moving the surefire
> >
> >>  plugin
> >>>>   to failsafe.
> >>>>
> >>>>   LieGrue,
> >>>>   strub
> >>>>
> >>>>
> >>
> >>
> >>
> >>  --
> >>  Christian Kaltepoth
> >>  Blog: http://chkal.blogspot.com/
> >>  Twitter: http://twitter.com/chkal
> >>
> >
>



-- 
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp

Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling

PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message