deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerhard Petracek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DELTASPIKE-222) Add possibility to set base path
Date Sun, 08 Jul 2012 09:02:33 GMT

    [ https://issues.apache.org/jira/browse/DELTASPIKE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408875#comment-13408875
] 

Gerhard Petracek commented on DELTASPIKE-222:
---------------------------------------------

basically agreed and as i said i'm ok with it since you (usually) don't have a lot of different
(simple) message-sources and also inheritance for a fallback-lookup won't be needed extensively.
what i mentioned in my previous comment: using classes for it also allows further features
- e.g. we could provide JsfApplicationMessageBundle (#getKey would delegate to the faces-context
to resolve it), BeanValidationMessages, DeltaSpikeMessages,...
that means users don't have to know where it comes from and with std. java-ide support they
can find such bundles easily.
however, for sure you can do most of it with a custom message-resolver.

since there is no #config in the fluent-api any longer (which indicates that it is a part
of the config of the context), we just have to document it carefully to avoid that people
start doing e.g.:
this.messageContext.messageSource("msgsX.properties", "msgsY.properties") .message().template("{msgX}").toString();

however, as mentioned at the very beginning it's a bit more complex and i'm ok with the latest
change - we need a nice documentation in any case.
                
> Add possibility to set base path
> --------------------------------
>
>                 Key: DELTASPIKE-222
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-222
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: I18n-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>             Fix For: 0.3-incubating
>
>
> Add the possibility to set the base path, means the path to the properties file.
> Now they are assumed to be at same level as the @MessageResource annotated interface
is, in fact within the same package.
> Maybe someone wants to put his resource bundles at /META-INF/resources/*.properties.
> With cal10n it was possible to set the Base with @Base("/META-INF/resources")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message