Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltaspike-dev@incubator.apache.org
Date: Tue, 12 Jun 2012 07:50:43 +0000 (UTC)
From: "Gerhard Petracek (JIRA)" <jira@apache.org>
To: deltaspike-dev@incubator.apache.org
Message-ID: <401050002.6340.1339487443967.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1024037226.4051.1339445862594.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (DELTASPIKE-191) get rid of
 BeanManagerProvider#setTestMode()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DELTASPIKE-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293420#comment-13293420 ] 

Gerhard Petracek commented on DELTASPIKE-191:
---------------------------------------------

+1 to get rid of the workaround!
however, the current draft will cause strange side-effects (in many cases not deterministic due to the unspecified order of observers), if users use #getBeanManager in a custom AfterDeploymentValidation observer.
in case of weld it will finally store and return the bean-manager used for the latest bda (which isn't the bm exposed via jndi).
                
> get rid of BeanManagerProvider#setTestMode()
> --------------------------------------------
>
>                 Key: DELTASPIKE-191
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-191
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.2-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.3-incubating
>
>
> this is an absolute antipattern and we must remove it asap!
> We also need to review all the RootBeanManagerProvider pattern. This seems like huge tons of code just to provide a workaround for a broken container.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira