Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltaspike-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.de;
  h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=SzELN+M8UabjUuzY0MvC8kTcuUi4QIjnIPbjUw1PbG4Ik9fY8fax35AaFjm/h6SpBhiwnqywSR716VGydIMiGCwJUNGJjl9aL3NSQ4tBpW0iL7QElUVG0FgzkwSFhh4O/N5OLyvTxBNDFt/sLTXwd0onnCEOdo2Wzt93y2VUr84=;
References: <20120614062610.11E6D11397@tyr.zones.apache.org>
 <CAF9TksMwQdv7TRDBqS66saw-Z_YgtS07VLF_T-LLG7BnHYfCbA@mail.gmail.com>
 <CAGJtJfEoJYsWi5i0Wvc4ym8eAvVZmj+PW+ycm_+KAwzwBCvGkQ@mail.gmail.com>
Message-ID: <1339709890.19575.YahooMailNeo@web171501.mail.ir2.yahoo.com>
Date: Thu, 14 Jun 2012 22:38:10 +0100 (BST)
From: Mark Struberg <struberg@yahoo.de>
Reply-To: Mark Struberg <struberg@yahoo.de>
Subject: Re: git commit: DELTASPIKE-196 NO integration with Exception Handler
 needed!
To: "deltaspike-dev@incubator.apache.org"
 <deltaspike-dev@incubator.apache.org>
In-Reply-To: 
 <CAGJtJfEoJYsWi5i0Wvc4ym8eAvVZmj+PW+ycm_+KAwzwBCvGkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Well, this is split. The native underlying impl is already being used durin=
g bootstrap by Extensions.=0AThe injection stuff can of course only be perf=
ormed after the container did finally boot.=0A=0ALieGrue,=0Astrub=0A=0A=0A=
=0A----- Original Message -----=0A> From: Gerhard Petracek <gerhard.petrace=
k@gmail.com>=0A> To: deltaspike-dev@incubator.apache.org=0A> Cc: =0A> Sent:=
 Thursday, June 14, 2012 11:23 PM=0A> Subject: Re: git commit: DELTASPIKE-1=
96 NO integration with Exception Handler needed!=0A> =0A> right now we don'=
t do it during the bootstrapping process (it's done =0A> lazily=0A> during =
runtime).=0A> =0A> the basic question is where and how we integrate our own=
 exception handling=0A> mechanism in the rest of deltaspike.=0A> and i thin=
k jason is the expert for it since he wrote the catch module.=0A> =0A> rega=
rds,=0A> gerhard=0A> =0A> =0A> =0A> 2012/6/14 Jason Porter <lightguard.jp@g=
mail.com>=0A> =0A>>  Gerhard asked me to take a look at this, and I didn't =
have the full =0A> context=0A>>  on IRC. In speaking with him it sounded li=
ke a good idea to use the DS=0A>>  exception handling here, however, Mark m=
akes an excellent point about not=0A>>  really being able to solve this wit=
hout user intervention. We could use=0A>>  exception handling here and if t=
here isn't any thing to handle it, we =0A> could=0A>>  rethrow the exceptio=
n and halt the deployment anyway.=0A>> =0A>>  Another thought just occurred=
 to me, because we're really doing this =0A> before=0A>>  the application f=
ully completes deployment, I'm not even 100% sure=0A>>  DeltaSpike exceptio=
n handling would work, that's probably an =0A> implementation=0A>>  specifi=
c detail. In light of those two ideas, I'm going to stand by =0A> Mark=0A>>=
  and say we should leave it out.=0A>> =0A>>  On Thu, Jun 14, 2012 at 12:26=
 AM, <struberg@apache.org> wrote:=0A>> =0A>>  > Updated Branches:=0A>>  >=
=A0 refs/heads/master 9ca1855d7 -> 1c6354650=0A>>  >=0A>>  >=0A>>  > DELTAS=
PIKE-196 NO integration with Exception Handler needed!=0A>>  >=0A>>  > The =
DS Exception=A0 Handler is for _business_ methods.=0A>>  > Technical and co=
nfiguration issues shall not be handled by DS=0A>>  > but by the user. We c=
annot recover from it without any=0A>>  > user interaction anyway...=0A>>  =
>=0A>>  >=0A>>  > Project:=0A>>  http://git-wip-us.apache.org/repos/asf/inc=
ubator-deltaspike/repo=0A>>  > Commit:=0A>>  >=0A>>  http://git-wip-us.apac=
he.org/repos/asf/incubator-deltaspike/commit/1c635465=0A>>  > Tree:=0A>>  >=
=0A>>  http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/1c6=
35465=0A>>  > Diff:=0A>>  >=0A>>  http://git-wip-us.apache.org/repos/asf/in=
cubator-deltaspike/diff/1c635465=0A>>  >=0A>>  > Branch: refs/heads/master=
=0A>>  > Commit: 1c63546506457e1a74fed6ca92cb9d0c0d54a2fc=0A>>  > Parents: =
9ca1855=0A>>  > Author: Mark Struberg <struberg@apache.org>=0A>>  > Authore=
d: Thu Jun 14 07:55:52 2012 +0200=0A>>  > Committer: Mark Struberg <struber=
g@apache.org>=0A>>  > Committed: Thu Jun 14 07:55:52 2012 +0200=0A>>  >=0A>=
>  > ----------------------------------------------------------------------=
=0A>>  >=A0 .../impl/config/DefaultConfigPropertyProducer.java |=A0 =A0 3 -=
--=0A>>  >=A0 1 files changed, 0 insertions(+), 3 deletions(-)=0A>>  > ----=
------------------------------------------------------------------=0A>>  >=
=0A>>  >=0A>>  >=0A>>  >=0A>> =0A> http://git-wip-us.apache.org/repos/asf/i=
ncubator-deltaspike/blob/1c635465/deltaspike/core/impl/src/main/java/org/ap=
ache/deltaspike/core/impl/config/DefaultConfigPropertyProducer.java=0A>>  >=
 ----------------------------------------------------------------------=0A>=
>  > diff --git=0A>>  >=0A>> =0A> a/deltaspike/core/impl/src/main/java/org/=
apache/deltaspike/core/impl/config/DefaultConfigPropertyProducer.java=0A>> =
 >=0A>> =0A> b/deltaspike/core/impl/src/main/java/org/apache/deltaspike/cor=
e/impl/config/DefaultConfigPropertyProducer.java=0A>>  > index d878139..cd4=
422e 100644=0A>>  > ---=0A>>  >=0A>> =0A> a/deltaspike/core/impl/src/main/j=
ava/org/apache/deltaspike/core/impl/config/DefaultConfigPropertyProducer.ja=
va=0A>>  > +++=0A>>  >=0A>> =0A> b/deltaspike/core/impl/src/main/java/org/a=
pache/deltaspike/core/impl/config/DefaultConfigPropertyProducer.java=0A>>  =
> @@ -54,7 +54,6 @@ public class DefaultConfigPropertyProducer extends=0A>>=
  > BaseConfigPropertyProducer=0A>>  >=A0 =A0 =A0 =A0 =A0 =A0  return null;=
=0A>>  >=A0 =A0 =A0 =A0  }=0A>>  >=0A>>  > -=A0 =A0 =A0 =A0 //X TODO integr=
ate with the HandledHandler of DeltaSpike=0A>>  >=A0 =A0 =A0 =A0  return In=
teger.parseInt(configuredValue);=0A>>  >=A0 =A0  }=0A>>  >=0A>>  > @@ -69,7=
 +68,6 @@ public class DefaultConfigPropertyProducer extends=0A>>  > BaseCo=
nfigPropertyProducer=0A>>  >=A0 =A0 =A0 =A0 =A0 =A0  return null;=0A>>  >=
=A0 =A0 =A0 =A0  }=0A>>  >=0A>>  > -=A0 =A0 =A0 =A0 //X TODO integrate with=
 the HandledHandler of DeltaSpike=0A>>  >=A0 =A0 =A0 =A0  return Long.parse=
Long(configuredValue);=0A>>  >=A0 =A0  }=0A>>  >=0A>>  > @@ -108,7 +106,6 @=
@ public class DefaultConfigPropertyProducer extends=0A>>  > BaseConfigProp=
ertyProducer=0A>>  >=A0 =A0 =A0 =A0  }=0A>>  >=0A>>  >=A0 =A0 =A0 =A0  //X =
TODO think about something like @NumberFormat(...)=0A>>  > -=A0 =A0 =A0 =A0=
 //X TODO integrate with the HandledHandler of DeltaSpike=0A>>  >=A0 =A0 =
=A0 =A0  return Float.parseFloat(configuredValue);=0A>>  >=A0 =A0  }=0A>>  =
>=A0 }=0A>>  >=0A>>  >=0A>> =0A>> =0A>>  --=0A>>  Jason Porter=0A>>  http:/=
/lightguard-jp.blogspot.com=0A>>  http://twitter.com/lightguardjp=0A>> =0A>=
>  Software Engineer=0A>>  Open Source Advocate=0A>>  Author of Seam Catch =
- Next Generation Java Exception Handling=0A>> =0A>>  PGP key id: 926CCFF5=
=0A>>  PGP key available at: keyserver.net, pgp.mit.edu=0A>> =0A>