deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerhard Petracek (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DELTASPIKE-191) get rid of BeanManagerProvider#setTestMode()
Date Tue, 12 Jun 2012 07:55:42 GMT

    [ https://issues.apache.org/jira/browse/DELTASPIKE-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293420#comment-13293420
] 

Gerhard Petracek edited comment on DELTASPIKE-191 at 6/12/12 7:55 AM:
----------------------------------------------------------------------

+1 to get rid of the workaround!
however, the current draft will cause strange side-effects (in many cases not deterministic
due to the unspecified order of observers), if users use #getBeanManager in a custom AfterDeploymentValidation
observer (not suggested, but possible).
in case of weld it will finally store and return the bean-manager used for the latest bda
(which isn't the bm exposed via jndi).
                
      was (Author: gpetracek):
    +1 to get rid of the workaround!
however, the current draft will cause strange side-effects (in many cases not deterministic
due to the unspecified order of observers), if users use #getBeanManager in a custom AfterDeploymentValidation
observer.
in case of weld it will finally store and return the bean-manager used for the latest bda
(which isn't the bm exposed via jndi).
                  
> get rid of BeanManagerProvider#setTestMode()
> --------------------------------------------
>
>                 Key: DELTASPIKE-191
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-191
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.2-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.3-incubating
>
>
> this is an absolute antipattern and we must remove it asap!
> We also need to review all the RootBeanManagerProvider pattern. This seems like huge
tons of code just to provide a workaround for a broken container.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message