deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gerhard Petracek <gerhard.petra...@gmail.com>
Subject Re: [DISCUSS] DELTASPIKE-131 Discuss the concept of exception handlers
Date Mon, 09 Apr 2012 10:31:03 GMT
i changed it in the wiki.

@ jason:
it would be great if you can commit the basic approach and refactor it to
the api we have discussed.

regards,
gerhard



2012/4/4 Pete Muir <pmuir@redhat.com>

> +1 to @BeforeHandles.
>
> On 4 Apr 2012, at 08:44, Gerhard Petracek wrote:
>
> > hi @ all,
> >
> > jason and i updated the current draft [1] -> please review it.
> >
> > before jason will commit it (by the end of the week), we would like to
> > discuss TraversalMode.
> >
> > currently there are 2 modes DEPTH_FIRST (default) and BREADTH_FIRST.
> > the usage of the 2nd one is:
> > @Handles(during = TraversalMode.BREADTH_FIRST)
> >
> > handlers with the mode BREADTH_FIRST are more callbacks before the
> handlers
> > with the mode DEPTH_FIRST process the exception.
> > -> an alternative for
> > @Handles(during = TraversalMode.BREADTH_FIRST)
> > would be e.g.
> > @BeforeHandles
> >
> > the behaviour of @BeforeHandles would be the same (it's just a 2nd
> > annotation instead of the enum).
> > -> we would have
> > @BeforeHandles and @Handles
> > instead of
> > @Handles and TraversalMode
> >
> > imo:
> > advantages: @BeforeHandles is shorter and easier for users because you
> > clearly see that there is a 2nd concept and it's pretty easy to get the
> > intention (TraversalMode sounds more complex and you have to check the
> > documentation what it really means whereas @BeforeHandles is quite
> > intuitive.)
> >
> > disadvantage: there are two annotations you have to know (they are easy
> but
> > you have to know both)
> >
> > regards,
> > gerhard
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/display/DeltaSpike/Exception+Control+Drafts
> >
> >
> >
> > 2012/3/30 Gerhard Petracek <gerhard.petracek@gmail.com>
> >
> >> +1
> >>
> >> regards,
> >> gerhard
> >>
> >>
> >>
> >>
> >> 2012/3/30 Jason Porter <lightguard.jp@gmail.com>
> >>
> >>> In that case, I suggest we start with the exception handler portion
> >>> (defining them, calling them, etc) we can do the advanced stuff later.
> >>>
> >>> On Fri, Mar 30, 2012 at 02:20, Gerhard Petracek
> >>> <gerhard.petracek@gmail.com>wrote:
> >>>
> >>>> hi jason,
> >>>>
> >>>> it was a whole module -> it is more than a single feature -> i
would
> >>> prefer
> >>>> to do it step by step similar to what we are doing with the security
> >>>> module.
> >>>>
> >>>> regards,
> >>>> gerhard
> >>>>
> >>>>
> >>>>
> >>>> 2012/3/27 Jason Porter <lightguard.jp@gmail.com>
> >>>>
> >>>>> fyi: please check [1] before you answer.
> >>>>>
> >>>>> The JIRA issue has the concept outlined (and the parent has slides
> >>> from a
> >>>>> presentation I did last year). You can find the implementation at
[2]
> >>> and
> >>>>> [2a].
> >>>>>
> >>>>> please send
> >>>>> +1, +0 or -1 because...
> >>>>> for the basic idea as well as the basic concept.
> >>>>> if there are >basic< objections, please also add them to [3]
> >>>>>
> >>>>> regards,
> >>>>> gerhard
> >>>>>
> >>>>> [1] http://markmail.org/message/7yefspfuvtz4jvmp
> >>>>> [2]
> >>>>>
> >>>>>
> >>>>
> >>>
> https://github.com/seam/solder/tree/develop/impl/src/main/java/org/jboss/solder/exception
> >>>>> [2a]
> >>>>>
> >>>>>
> >>>>
> >>>
> https://github.com/seam/solder/tree/develop/api/src/main/java/org/jboss/solder/exception
> >>>>> [3]
> >>>>>
> >>>>
> >>>
> https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
> >>>>>
> >>>>> --
> >>>>> Jason Porter
> >>>>> http://lightguard-jp.blogspot.com
> >>>>> http://twitter.com/lightguardjp
> >>>>>
> >>>>> Software Engineer
> >>>>> Open Source Advocate
> >>>>> Author of Seam Catch - Next Generation Java Exception Handling
> >>>>>
> >>>>> PGP key id: 926CCFF5
> >>>>> PGP key available at: keyserver.net, pgp.mit.edu
> >>>>>
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Jason Porter
> >>> http://lightguard-jp.blogspot.com
> >>> http://twitter.com/lightguardjp
> >>>
> >>> Software Engineer
> >>> Open Source Advocate
> >>> Author of Seam Catch - Next Generation Java Exception Handling
> >>>
> >>> PGP key id: 926CCFF5
> >>> PGP key available at: keyserver.net, pgp.mit.edu
> >>>
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message