Return-Path: X-Original-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 208DBBC00 for ; Fri, 20 Jan 2012 07:18:29 +0000 (UTC) Received: (qmail 74744 invoked by uid 500); 20 Jan 2012 07:18:25 -0000 Delivered-To: apmail-incubator-deltaspike-dev-archive@incubator.apache.org Received: (qmail 74671 invoked by uid 500); 20 Jan 2012 07:18:13 -0000 Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: deltaspike-dev@incubator.apache.org Delivered-To: mailing list deltaspike-dev@incubator.apache.org Received: (qmail 74657 invoked by uid 99); 20 Jan 2012 07:18:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2012 07:18:08 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of gerhard.petracek@gmail.com designates 209.85.213.175 as permitted sender) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2012 07:18:03 +0000 Received: by yenr5 with SMTP id r5so114323yen.6 for ; Thu, 19 Jan 2012 23:17:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=g2J/LsQlDQnL9PK4CfT5WfbaR+BqVHDKcTmr5bVJlIs=; b=IcLDgGDa72FVn+8gnz8sLtUInTBZqGGRVf2C5CNLTUAqedwiYaqHblTRTsfd3chjD8 E0PDkjXkI2C/nuqjTXjgK9U2vL8q5tkT8nipsXgHdSSXGNrWvise4ZgjTZXdEy0DEFkb EiiPM8/t5atqz/epUAH/RDnDVmyT7jPMMSAG8= Received: by 10.236.187.34 with SMTP id x22mr3680349yhm.14.1327043863187; Thu, 19 Jan 2012 23:17:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.236.27.68 with HTTP; Thu, 19 Jan 2012 23:17:21 -0800 (PST) In-Reply-To: References: <0DFD8942-A8A1-49EE-9143-1E1E17B4E65E@gmail.com> From: Gerhard Petracek Date: Fri, 20 Jan 2012 08:17:21 +0100 Message-ID: Subject: Re: [DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations To: deltaspike-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 hi @ all, if there are no objections i'll push it by the end of the day. jason thought about creating (jira-)sub-tasks for every literal. since the implementation itself isn't in question, i'll push the commit as it is and if we think that we don't need one of the literals we can remove it again. regards, gerhard 2012/1/19 Christian Kaltepoth : > +1 > > 2012/1/18 Jason Porter : >> +1 for the annotation literals. IMO, the spec should have literals for all the annotations it defines. >> >> Sent from my iPhone >> >> On Jan 18, 2012, at 9:49, Pete Muir wrote: >> >>> +1 >>> >>> On 18 Jan 2012, at 16:47, Gerhard Petracek wrote: >>> >>>> hi @ all, >>>> >>>> while reviewing DELTASPIKE-45 i saw that some literal implementations for >>>> std. cdi annotations got into deltaspike as well. >>>> in myfaces codi we also have some literal implementations. esp. for >>>> DELTASPIKE-45 they make a lot of sense imo. >>>> -> i created DELTASPIKE-53 and since there is just one std. way to >>>> implement them, i pushed a preview to [1]. >>>> >>>> if we agree that those literal implementations for std. cdi annotations >>>> should be included, i'll push the missing implementations. >>>> >>>> regards, >>>> gerhard >>>> >>>> [1] http://s.apache.org/ja >>> > > > > -- > Christian Kaltepoth > Blog: http://chkal.blogspot.com/ > Twitter: http://twitter.com/chkal