Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltaspike-dev@incubator.apache.org
Date: Sun, 22 Jan 2012 11:55:39 +0000 (UTC)
From: "Mark Struberg (Commented) (JIRA)" <jira@apache.org>
To: deltaspike-dev@incubator.apache.org
Message-ID: 
 <1758214960.64423.1327233339849.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <708635765.35319.1324473810538.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DELTASPIKE-24) Deactivatable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190653#comment-13190653 ] 

Mark Struberg commented on DELTASPIKE-24:
-----------------------------------------

The current code is pretty nice if a given ClassDeactivator doesn't exist.

>            currentClassDeactivator =
>                    ClassUtils.tryToInstantiateClassForName(classDeactivatorClassName, ClassDeactivator.class);
> ... if null... LOG.warning(classDeactivatorClassName + " can't be instantiated");

I think this is way to nice. If someone configured a not existing ClassDeactivator, then the system should just blow up. This is most probably a misspelling on the class name and thus a serious problem.
                
> Deactivatable
> -------------
>
>                 Key: DELTASPIKE-24
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Gerhard Petracek
>            Assignee: Mark Struberg
>             Fix For: 0.1
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira