deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gerhard Petracek <gerhard.petra...@gmail.com>
Subject Re: [DISCUSS] (DELTASPIKE-15) @DefaultBean
Date Fri, 27 Jan 2012 16:19:32 GMT
i'm fine with that!

regards,
gerhard



2012/1/27 Jason Porter <lightguard.jp@gmail.com>:
> I think what we have is good for now. We can add to it later. I'm at a -1 for adding
a flag for the easier route. IMO that would only complicate it more. If this solution works
for everything I say we just leave it at that.
>
> Sent from my iPhone
>
> On Jan 27, 2012, at 0:33, Gerhard Petracek <gerhard.petracek@gmail.com> wrote:
>
>> thx jason for reviewing it!
>> :) yes - the simpler version is easier because the trick itself is easier -
>> but it won't work e.g. for WAS8.
>>
>> what we could  introduce in addition (if we see a need for it later on):
>> - a config option to switch to the easier approach
>> - a mechanism to allow the execution of bootstrapping events in a
>> specified order (at least for deltaspike modules)
>> - additional features which aren't supported by cdi (1.0)
>>
>> regards,
>> gerhard
>>
>>
>>
>> 2012/1/27 Jason Porter <lightguard.jp@gmail.com>
>>
>>> Looks good Gerhard. I had to go through it a couple of times to makes sure
>>> I got it (of course that may be because I'm tired right now), but it looks
>>> good.
>>>
>>> On Thu, Jan 26, 2012 at 17:56, Gerhard Petracek
>>> <gerhard.petracek@gmail.com>wrote:
>>>
>>>> hi @ all,
>>>>
>>>> i implemented the qualifier logic and pushed the current version to [1].
>>> (i
>>>> tested it with different servers.)
>>>> (i also did/tried an even simpler approach [2]. however, due to a
>>> stricter
>>>> check in owb the simpler approach doesn't work there.)
>>>> due to the current approach i added the implementation to the exclude
>>>> extension
>>>> (otherwise @Exclude wouldn't be compatible with global alternatives
>>> because
>>>> the annotated-type gets "moved").
>>>>
>>>> you can see all use-cases which are supported already in the tests [3].
>>>>
>>>> it would be nice, if you review it before we continue with the
>>> discussion.
>>>> esp. we have to check if there are constellations which aren't supported
>>>> right now (and there is no todo for it in the source-code).
>>>>
>>>> regards,
>>>> gerhard
>>>>
>>>> [1] https://github.com/os890/DS_Discuss/tree/DS61
>>>> [2] https://github.com/os890/DS_Discuss/tree/DS61weld
>>>> [3]
>>>>
>>>>
>>> https://github.com/os890/DS_Discuss/tree/DS61/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/alternative
>>>>
>>>>
>>>>
>>>>
>>>> 2012/1/26 Pete Muir <pmuir@redhat.com>
>>>>
>>>>> I like Gerhard's idea. Much more in keeping with the "right" way to do
>>>> it.
>>>>>
>>>>> On 25 Jan 2012, at 21:54, Jason Porter wrote:
>>>>>
>>>>>> If we do go this route, we certainly need to document it well as
is
>>>>>> different than what's supplied via vanilla CDI. I'm fine going ahead
>>>> and
>>>>>> trying it out though.
>>>>>>
>>>>>> On Wed, Jan 25, 2012 at 14:40, Gerhard Petracek
>>>>>> <gerhard.petracek@gmail.com>wrote:
>>>>>>
>>>>>>> in myfaces codi we had different approaches for it. the problem
was
>>>> that
>>>>>>> sometimes an approach stopped working on some new versions of
>>>> different
>>>>>>> servers (i just skip the details).
>>>>>>> that was the reason why we refactored it to a more explicit
>>> approach.
>>>> it
>>>>>>> isn't the most elegant one, but it works with all compatible
>>>>> environments.
>>>>>>>
>>>>>>> @default-bean:
>>>>>>> i gave my +1 because this concept is generic and therefore it
fits
>>>>> better
>>>>>>> (if it works with all (new) environments).
>>>>>>>
>>>>>>> however, i just looked at the details and i don't think that
we need
>>>>> that
>>>>>>> much magic - at least we can try to avoid it.
>>>>>>>
>>>>>>> imo: what we really need is @Alternative which works across BDAs.
>>> what
>>>>> we
>>>>>>> can do is to keep @Alternative and its basic contract, but instead
>>> of
>>>>>>> configuring it via the beans.xml we use our low-level config.
>>>>>>> an extension just checks if there is a configured alternative.
if it
>>>>> fits
>>>>>>> (it has the same qualifiers), the original AnnotatedType gets
>>> replaced
>>>>> with
>>>>>>> the configured alternative (+ the annotation @Alternative gets
>>>> removed).
>>>>>>> furthermore, we can veto the alternative itself to ensure that
it
>>>>> doesn't
>>>>>>> get activated as soon as an application gets deployed to a java-ee
>>>>> server
>>>>>>> with cdi 1.1. we just have to document that such an entry in
the
>>>>> low-level
>>>>>>> detaspike config is needed, if an alternative should work across
>>> BDAs.
>>>>>>>
>>>>>>> i prototyped it and tested simple cases already. if we agree
to give
>>>> the
>>>>>>> basic idea a try, i'll finish the prototype (so far i haven't
>>>>> implemented
>>>>>>> the qualifier logic).
>>>>>>>
>>>>>>> regards,
>>>>>>> gerhard
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2011/12/23 Christian Kaltepoth <christian@kaltepoth.de>
>>>>>>>
>>>>>>>> +1
>>>>>>>>
>>>>>>>> 2011/12/23 Gerhard Petracek <gerhard.petracek@gmail.com>:
>>>>>>>>> +1 if we keep the impl in impl-bda [1]
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> gerhard
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>>
>>>>>>>
>>>>>
>>> https://cwiki.apache.org/confluence/display/DeltaSpike/Project+Structure
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2011/12/23 Jason Porter <lightguard.jp@gmail.com>
>>>>>>>>>
>>>>>>>>>> fyi: please check [1] before you answer.
>>>>>>>>>>
>>>>>>>>>> [2] is the implementation used in Solder. The use
case for it
>>>> really
>>>>>>>> seems
>>>>>>>>>> more like @Typed, but in practice it's being used
to go around
>>> BDA
>>>>>>>> issues
>>>>>>>>>> in containers.
>>>>>>>>>>
>>>>>>>>>> the basic concept:
>>>>>>>>>> Provides a bean with a type and qualifiers that may
be different
>>>> than
>>>>>>>> the
>>>>>>>>>> concrete type.
>>>>>>>>>>
>>>>>>>>>> please send
>>>>>>>>>> +1, +0 or -1 because...
>>>>>>>>>> for the basic idea as well as the basic concept.
>>>>>>>>>> if there are >basic< objections, please also
add them to [3]
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [1] http://markmail.org/message/7yefspfuvtz4jvmp
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>> http://docs.jboss.org/seam/3/3.1.0.CR1/reference/en-US/html/solder-defaultbeans.html
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Jason Porter
>>>>>>>>>> http://lightguard-jp.blogspot.com
>>>>>>>>>> http://twitter.com/lightguardjp
>>>>>>>>>>
>>>>>>>>>> Software Engineer
>>>>>>>>>> Open Source Advocate
>>>>>>>>>> Author of Seam Catch - Next Generation Java Exception
Handling
>>>>>>>>>>
>>>>>>>>>> PGP key id: 926CCFF5
>>>>>>>>>> PGP key available at: keyserver.net, pgp.mit.edu
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Christian Kaltepoth
>>>>>>>> Blog: http://chkal.blogspot.com/
>>>>>>>> Twitter: http://twitter.com/chkal
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jason Porter
>>>>>> http://lightguard-jp.blogspot.com
>>>>>> http://twitter.com/lightguardjp
>>>>>>
>>>>>> Software Engineer
>>>>>> Open Source Advocate
>>>>>> Author of Seam Catch - Next Generation Java Exception Handling
>>>>>>
>>>>>> PGP key id: 926CCFF5
>>>>>> PGP key available at: keyserver.net, pgp.mit.edu
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Jason Porter
>>> http://lightguard-jp.blogspot.com
>>> http://twitter.com/lightguardjp
>>>
>>> Software Engineer
>>> Open Source Advocate
>>> Author of Seam Catch - Next Generation Java Exception Handling
>>>
>>> PGP key id: 926CCFF5
>>> PGP key available at: keyserver.net, pgp.mit.edu
>>>

Mime
View raw message