deltaspike-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gerhard Petracek <gerhard.petra...@gmail.com>
Subject Re: Please review DELTASPIKE-45
Date Mon, 09 Jan 2012 15:17:19 GMT
since stu signed it, we can continue with it.

regards,
gerhard



2012/1/7 Mark Struberg <struberg@yahoo.de>

> Imo the impl looks quite fine. The classes are small enough and straight
> forward to keep it in the api module.
>
> One thing we would need is the iCLA from Stu. I've seen he wrote most of
> the stuff originally, and he is also on the initial committer list. But we
> didn't have an iCLA from him on file yet it seems [1].
>
> Stu, once we have your iCLA on file we can go forward importing this stuff.
>
> LieGrue,
> strub
>
>
>
> [1] http://people.apache.org/committer-index.html
>
>
> ----- Original Message -----
> > From: Gerhard Petracek <gerhard.petracek@gmail.com>
> > To: deltaspike-dev@incubator.apache.org
> > Cc:
> > Sent: Saturday, January 7, 2012 9:55 PM
> > Subject: Re: Please review DELTASPIKE-45
> >
> > hi jason,
> >
> > the only alternative which comes to my mind right now is to move the impl
> > classes to the impl module and to introduce e.g.:
> > org.apache.deltaspike.core.spi.metadata.AnnotatedTypeBuilderData and
> > AnnotatedTypeBuilder
> > just loads the impl via the low-level config mechanism (which will be
> > discussed soon).
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2012/1/7 Jason Porter <lightguard.jp@gmail.com>
> >
> >>  I have the classes all checked into my branch [1]. Please review. I
> know
> >>  many of them need Javadoc, so you can forget that part. Mainly the
> >>  AnnotatedTypeBuilder needed many classes that were in Solder Impl. As I
> >>  believe AnnotatedTypeBuilder is pretty helpful for everyone doing CDI
> >>  Extension development I put them all in api, so we'll have some *Impl
> >>  classes in api. If everyone is okay with that, great. Otherwise we may
> need
> >>  to find a new place to put them as we can't put them in impl and keep
> >>  AnnotatedTypeBuilder in api.
> >>
> >>  [1]
> https://github.com/LightGuard/incubator-deltaspike/tree/DELTASPIKE-45
> >>
> >>  --
> >>  Jason Porter
> >>  http://lightguard-jp.blogspot.com
> >>  http://twitter.com/lightguardjp
> >>
> >>  Software Engineer
> >>  Open Source Advocate
> >>  Author of Seam Catch - Next Generation Java Exception Handling
> >>
> >>  PGP key id: 926CCFF5
> >>  PGP key available at: keyserver.net, pgp.mit.edu
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message