Return-Path: X-Original-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A9CD9C4B for ; Mon, 26 Dec 2011 22:59:40 +0000 (UTC) Received: (qmail 13666 invoked by uid 500); 26 Dec 2011 22:59:40 -0000 Delivered-To: apmail-incubator-deltaspike-dev-archive@incubator.apache.org Received: (qmail 13638 invoked by uid 500); 26 Dec 2011 22:59:40 -0000 Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: deltaspike-dev@incubator.apache.org Delivered-To: mailing list deltaspike-dev@incubator.apache.org Received: (qmail 13630 invoked by uid 99); 26 Dec 2011 22:59:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Dec 2011 22:59:40 +0000 X-ASF-Spam-Status: No, hits=1.8 required=5.0 tests=FREEMAIL_REPLY,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sethfromaustria@gmail.com designates 209.85.220.175 as permitted sender) Received: from [209.85.220.175] (HELO mail-vx0-f175.google.com) (209.85.220.175) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Dec 2011 22:59:34 +0000 Received: by vcbf1 with SMTP id f1so8178263vcb.6 for ; Mon, 26 Dec 2011 14:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=hVT2iJMiis+IXOMobm9RcPPYejdQ+ynoi1C+I+ph2pw=; b=oJ8HEofIMws5VJPVK66BKdR1DjPgcEue8IMT2Errx6isTaKjc2ddivrf/v8daNMCn1 /Wawnj1dlimZNdYMmzIpKT3cWiz2RVpp2PdleQCWP3BTxsEWk3gYbAmkOfOyxDtGwKmX r/rjSeDr3lW+v+gPpQ0oe5VNjYVCEQkxgtzMg= MIME-Version: 1.0 Received: by 10.52.173.176 with SMTP id bl16mr12678497vdc.47.1324940353615; Mon, 26 Dec 2011 14:59:13 -0800 (PST) Sender: sethfromaustria@gmail.com Received: by 10.220.2.134 with HTTP; Mon, 26 Dec 2011 14:59:13 -0800 (PST) In-Reply-To: References: <20111223203311.541E01649B1@mx01.openknowledge.de> Date: Mon, 26 Dec 2011 23:59:13 +0100 X-Google-Sender-Auth: rmg23wQLXc3IUmmOg_Hy3F2Otjg Message-ID: Subject: Re: [DISCUSS] [DELTASPIKE-8] @Veto From: Jakob Korherr To: deltaspike-dev@incubator.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org +1 to @Veto and @Exclude Also I agree with Pete's comments about the other suggestions. Regards, Jakob 2011/12/24 Pete Muir : > We chose @Veto originally, as it didn't deviate from the spec's veto() me= thod, so should be less of a learning curve. I don't like @Deactivate as it= makes it sound like you have to activate other beans. @Ignore is too overl= oaded a term for me to be comfortable with it (@IgnoreWarnings). I like @Ex= clude as it's closest to what makes most intuitive sense. > > On 24 Dec 2011, at 09:33, Christian Kaltepoth wrote: > >> Perhaps we should build a list of all suggestions and then start a >> vote which one to use. >> >> I think these are the names that were suggested: >> >> @Veto >> @Skip >> @Exclude >> @Deactivate >> @Ignore >> >> >> >> 2011/12/23 Gerhard Petracek : >>> hi arne, >>> >>> would be also ok for me -> +1 >>> >>> regards, >>> gerhard >>> >>> >>> 2011/12/23 Arne Limburg >>> >>>> What about @Exclude? >>>> >>>> Cheers, >>>> Arne >>>> >>>> -----Urspr=C3=BCngliche Nachricht----- >>>> Von: Gerhard Petracek [mailto:gerhard.petracek@gmail.com] >>>> Gesendet: Freitag, 23. Dezember 2011 21:28 >>>> An: deltaspike-dev@incubator.apache.org >>>> Betreff: Re: [DISCUSS] [DELTASPIKE-8] @Veto >>>> >>>> +0.5 for @Skip >>>> as mentioned in the original thread @Veto is accurate from a technical >>>> perspective, but it sounds strange for users who aren't aware of the >>>> mechanism behind. >>>> >>>> if we are talking only about @Veto vs @Skip and not about the other >>>> alternatives: +1 for @Skip >>>> >>>> regards, >>>> gerhard >>>> >>>> >>>> >>>> 2011/12/23 Dan Allen >>>> >>>>> Veto is rationally the most appropriate since it directly translates >>>>> to calling ProcessAnnotatedType#veto() >>>>> >>>>> However, I'd like to offer one other alternative: >>>>> >>>>> @Skip >>>>> >>>>> While veto describes what the extension is doing internally, skip is >>>>> how the developer perceives the result of the action. The class is >>>>> "skipped over" during the scanning process. This is similar to the >>>>> suggestion @Ignore, and I think both would get the point across equal= ly >>>> well. >>>>> >>>>> -Dan >>>>> >>>>> p.s. Apologizes for dropping the rest of the thread. I wasn't >>>>> receiving messages when this thread started. >>>>> >>>>> -- >>>>> Dan Allen >>>>> Principal Software Engineer, Red Hat | Author of Seam in Action >>>>> Registered Linux User #231597 >>>>> >>>>> http://www.google.com/profiles/dan.j.allen#about >>>>> http://mojavelinux.com >>>>> http://mojavelinux.com/seaminaction >>>>> >>>> >> >> >> >> -- >> Christian Kaltepoth >> Blog: http://chkal.blogspot.com/ >> Twitter: http://twitter.com/chkal > --=20 Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at