Return-Path: X-Original-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-deltaspike-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C5FB78DE for ; Wed, 21 Dec 2011 13:30:17 +0000 (UTC) Received: (qmail 72083 invoked by uid 500); 21 Dec 2011 13:30:17 -0000 Delivered-To: apmail-incubator-deltaspike-dev-archive@incubator.apache.org Received: (qmail 72046 invoked by uid 500); 21 Dec 2011 13:30:17 -0000 Mailing-List: contact deltaspike-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: deltaspike-dev@incubator.apache.org Delivered-To: mailing list deltaspike-dev@incubator.apache.org Received: (qmail 72038 invoked by uid 99); 21 Dec 2011 13:30:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2011 13:30:17 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mwessendorf@gmail.com designates 209.85.213.175 as permitted sender) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2011 13:30:12 +0000 Received: by yenm12 with SMTP id m12so4404145yen.6 for ; Wed, 21 Dec 2011 05:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=IgBkrDbYQp9ba+29wpPsCLYZIQ96dT9Ly2B7gG2ixcg=; b=cqtDQz4rEHjI0rmMXtgtWSXMWRhv2s1m4NLBd6+hDkkzo0yh7SivY+BPggIUDRpN9T G/PBDbkoINOJqLBFsb/i184T/Sb1Vdi15mkEBsAvWIaSNTM+MBYMOjlzsSPBt7LyTSBt +w11VwaNQYnK70OWfxZPE4jmCq0QWPJGYYn4s= MIME-Version: 1.0 Received: by 10.236.197.72 with SMTP id s48mr9293578yhn.81.1324474192133; Wed, 21 Dec 2011 05:29:52 -0800 (PST) Sender: mwessendorf@gmail.com Received: by 10.101.67.6 with HTTP; Wed, 21 Dec 2011 05:29:52 -0800 (PST) In-Reply-To: <1324465230.57862.YahooMailNeo@web27803.mail.ukl.yahoo.com> References: <1323689042.53857.YahooMailNeo@web27807.mail.ukl.yahoo.com> <1323959464.10946.YahooMailNeo@web27806.mail.ukl.yahoo.com> <1324465230.57862.YahooMailNeo@web27803.mail.ukl.yahoo.com> Date: Wed, 21 Dec 2011 14:29:52 +0100 X-Google-Sender-Auth: nosAp_4U9-3fsijskpbc-7hZycY Message-ID: Subject: Re: basic decisions - package and class naming From: Matthias Wessendorf To: deltaspike-dev@incubator.apache.org, Mark Struberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2011 at 12:00 PM, Mark Struberg wrote: > As I see it we have 3 different options: > > 1.) .api.* + .impl.*=A0 because it's more easy to 'grab' any api package = in e.g. an Arquillian test. If we don't have the modulename.api package nam= e, then we cannot do something like this in Arquillian: > =A0 Shrinkwrap.createArchive(JavaArchive.class).addPackages(true, "...mod= ulename.api"); > > Without the explicit .api package name we would not be able to add just t= he api module without also adding all the impl stuff as well. (This is need= ed if we e.g. like to test single features of the impl module). Ok, I don't get the _why_; Do you mind to explain it to me (I know nothing about Arquillian and the shade plugin:-)) -M > > > The very same will hit us with the maven-shade-plugin where we would not = be able to explicitely shade all classes of the api modules. > > > > thus a +1 for this. > > > 2.) noting + '.internal' > > possible, but with the downsides as noted above. > -0.5 thus. > > LieGrue, > strub > > > > ----- Original Message ----- >> From: Antoine Sabot-Durand >> To: deltaspike-dev@incubator.apache.org >> Cc: >> Sent: Tuesday, December 20, 2011 11:55 AM >> Subject: Re: basic decisions - package and class naming >> >> Social API: >> org.apache.deltaspike.social.*=A0 =A0+1 >> >> the implementation >> org.apache.deltaspike.social.impl.*=A0 +0 (we don't have this in Seam an= d have >> the distinction in module name, but it's not a big deal for me) >> >> @SPI =3D> +0 I'm not sure to use it but why not. >> >> >> Antoine SABOT-DURAND >> >> Le 15 d=E9c. 2011 =E0 18:43, Matthias Wessendorf a =E9crit : >> >>> =A0On Thu, Dec 15, 2011 at 3:31 PM, Mark Struberg >> wrote: >>>> =A0Well, we are now hitting the wall - so we need a resolution asap. >>>> >>>> =A0For the core module we would have >>>> >>>> =A0for core-api: >>>> >>>> =A0org.apache.deltaspike.core. ....? >>>> >>>> =A0for core-impl: >>>> >>>> =A0org.apache.deltaspike.core.impl. ....? >>> >>> >>> =A0yes! >>> =A0And/or >>> >>> =A0JPA API: >>> =A0org.apache.deltaspike.jpa.* >>> >>> =A0the implementation >>> =A0org.apache.deltaspike.jpa.impl.* >>> >>> =A0@SPI =3D> fine for me! >>> >>> =A0But please NO 'api' inside of the pkg names; (impl is a must, IMO >>> =A0(fine in naming it 'internal', but I guess impl is more >> 'standard') >>> >>> =A0-M >>> >>>> >>>> >>>> =A0The problem is that by omitting the .api. package, we don't have >> any good handle to include/exclude all the classes from core.api, jsf.ap= i, etc >> in the maven-shade-plugin or any other include/exclude mechanism. That c= ould >> hurt a bit. >>>> >>>> =A0Matze, you have not been fond of the api package, what do you sugge= st >> as an alternative option? >>>> >>>> =A0LieGrue, >>>> =A0strub --=20 Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf