deltaspike-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From strub...@apache.org
Subject [7/7] git commit: review old TODOs and remove them if not valid anymore.
Date Sun, 23 Jun 2013 21:09:42 GMT
review old TODOs and remove them if not valid anymore.


Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/ec592a45
Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/ec592a45
Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/ec592a45

Branch: refs/heads/master
Commit: ec592a45194c1a126d861514e453ac9b7de7c5be
Parents: 2318498
Author: Mark Struberg <struberg@apache.org>
Authored: Sun Jun 23 18:14:20 2013 +0200
Committer: Mark Struberg <struberg@apache.org>
Committed: Sun Jun 23 18:14:20 2013 +0200

----------------------------------------------------------------------
 .../org/apache/deltaspike/core/util/ServiceUtils.java  |  2 --
 .../test/core/api/config/ConfigSourceTest.java         | 13 -------------
 2 files changed, 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/deltaspike/blob/ec592a45/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ServiceUtils.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ServiceUtils.java
b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ServiceUtils.java
index a02ec3e..0c1b994 100644
--- a/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ServiceUtils.java
+++ b/deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ServiceUtils.java
@@ -44,8 +44,6 @@ public abstract class ServiceUtils
 
         if (!servicesIterator.hasNext())
         {
-            //X TODO check if we have to do it in any case with different packaging constellations
-            //X and merge the result in any case
             ClassLoader fallbackClassLoader = ServiceUtils.class.getClassLoader();
             servicesIterator = ServiceLoader.load(serviceType, fallbackClassLoader).iterator();
         }

http://git-wip-us.apache.org/repos/asf/deltaspike/blob/ec592a45/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/config/ConfigSourceTest.java
----------------------------------------------------------------------
diff --git a/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/config/ConfigSourceTest.java
b/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/config/ConfigSourceTest.java
index 3bbccff..79aa6ba 100644
--- a/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/config/ConfigSourceTest.java
+++ b/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/api/config/ConfigSourceTest.java
@@ -86,18 +86,5 @@ public class ConfigSourceTest
         Assert.assertEquals(value, configuredValue);
     }
 
-    /*
-    //X TODO discuss marker
-    @Test
-    public void testConfigViaSystemPropertyAndMarker()
-    {
-        String key = "testProperty01";
-        String value = "test_value";
-        System.setProperty("org.apache.deltaspike." + key, value);
 
-        String configuredValue = ConfigResolver.getPropertyValue("@@deltaspike@@" + key);
-
-        Assert.assertEquals(value, configuredValue);
-    }
-    */
 }


Mime
View raw message