deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marios Andreou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DTACLOUD-574) Address Model should allow the use of an actual identifier for an instance instead of just the IP
Date Wed, 17 Jul 2013 07:54:48 GMT

    [ https://issues.apache.org/jira/browse/DTACLOUD-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710833#comment-13710833
] 

Marios Andreou commented on DTACLOUD-574:
-----------------------------------------

Hi [~inspectrum] - sorry it has taken me a while to get to this:

* I can't apply the attached patch. I tried both 'git am' and 'git apply':

[m@m core]$ cat /home/m/Documents/WORK/Patches/JIRA/DTACLOUD-574/add_address_ip.diff  | git
am
Patch does not have a valid e-mail address.
[m@m core]$ cat /home/m/Documents/WORK/Patches/JIRA/DTACLOUD-574/add_address_ip.diff  | git
apply
fatal: corrupt patch at line 12

* Why are you adding an 'href' attribute to the model? Is this required for your purposes
- convention thus far has just been to add the href in serialization.

* The part I can't see in this patch is the OpenStack (OS) driver side of things, where you're
assigning OS.Address.uuid to Deltacloud.Address.id and OS.Address.IP to DC.Address.IP. Since
the current OS driver doesn't have support for Elastic IP Address I can't add it there, so
I guess you'll be submitting those changes with your updated driver when its ready.

Other than the comment/query about href above, I'm happy to push these changes - but I can't
until you give me a patch that I can apply :)

thanks! marios


                
> Address Model should allow the use of an actual identifier for an instance instead of
just the IP
> -------------------------------------------------------------------------------------------------
>
>                 Key: DTACLOUD-574
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-574
>             Project: DeltaCloud
>          Issue Type: Bug
>          Components: Server
>            Reporter: Andrew Brady
>            Priority: Minor
>              Labels: easyfix
>         Attachments: add_address_ip.diff
>
>
> The model for Address doesn't support setting both the address and the id. And, since
it doesn't support setting the href it doesn't allow accessing an address specifically by
id (which is how you would do it in OpenStack).
> Even just making the "to_hash" method on Address use a ternary on href and making that
attribute settable would be an acceptable solution. The only real use case is to be able to
retrieve address details for an individual address.
> An example from mock driver:
> <address href="http://localhost:3001/api/addresses/192.168.0.4" id="192.168.0.4"><ip>192.168.0.4</ip><actions><link
href="http://localhost:3001/api/addresses/192.168.0.4" method="delete" rel="destroy"/><link
href="http://localhost:3001/api/addresses/192.168.0.4/associate" method="post" rel="associate"/></actions></address>
> But 192.168.0.4 isn't an id, it's an IP

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message