deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH] SITE: Update test recording instructions
Date Tue, 12 Mar 2013 22:26:52 GMT
On Tue, 2013-03-12 at 17:39 -0400, jvlcek@redhat.com wrote:
> From: Joe VLcek <jvlcek@redhat.com>
> 
> This is required to better describe recent changes
> for parameterizing recording and provider configuration
> of credentials and resources to avoid having to edit
> test source code in order to record test fixtures.
> ---
>  site/content/running-the-white-box-tests.md        | 25 ++++--
>  .../update-vcr-test-fixtures-data-example.md       | 95 ++++++----------------
>  site/output/running-the-white-box-tests.html       | 25 ++++--
>  .../update-vcr-test-fixtures-data-example.html     | 94 ++++++---------------
>  4 files changed, 84 insertions(+), 155 deletions(-)

> diff --git a/site/content/update-vcr-test-fixtures-data-example.md b/site/content/update-vcr-test-fixtures-data-example.md
> index 2f8074a..ef64573 100644
> --- a/site/content/update-vcr-test-fixtures-data-example.md
> +++ b/site/content/update-vcr-test-fixtures-data-example.md
> @@ -29,62 +29,44 @@ More information can be found on the past recording of the
>  <ol>
>    <li>
>      <p> Create ${HOME}/.deltacloud/config</p>
> +    <br>
> +    <p> Create the deltacloud config file: ${HOME}/.deltacloud/config</p>
> +    to contain the credentials and provider resource UUIDs</p>
>  
>      <pre>
>      rhevm:
>        user:     'admin@internal'
>        password: 'localpassword'
> -      provider: 'https://16.1.1.3/api;b9bb11c2-f397-4f41-a57b-7ac15a894779'
> -    mock:
> -      user: mockuser
> -      password: mockpassword
> -      provider: compute
> +      provider: 'https://rhevm.example.com/api'
> +      preferred:
> +        datacenter: UUID of a datacenter/realm
> +        vm: UUID of an existing instance
> +        template: UUID of an existing template/image

Why did you remove mock here ? It was a good way to show people how to
add credentials for additional drivers. It's also useful when you run
'deltacloudd -c'

> -    <p>Modify the test source to have the realm, instance, image & provider
> -       for a live cloud provider.</p>
> +    <p>Set the VCR record mode to <i>all</i></p>
> +    <br>
> +    <p> Note: This does not cause <i>all</i> tests to be recorded.
> +    It instructs VCR to record new fixtures data for the test to
> +    be run in the next step.</p>

Can you modify the other tests to use VCR_RECORD to trigger recording ?

>      <p>Remove ${HOME}/.deltacloud/config</p>

This is not needed anymore - it doesn't matter whether you have that
file in place or not during playback.

>    <li>
> -    <p>Remove trailing white space from the fixtures YAML files.</p>
> +    <p>Deal sith trailing white space from the fixtures YAML files.</p>

Tyop, and I don't think we need this section. It's fine to check the
YAML files in with trailing ws.

David



Mime
View raw message