Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] rhevm: DTACLOUD-452: expose create_image action only when
 stopped
Date: Wed, 6 Feb 2013 21:00:46 +1100
Message-ID: <434A0ECB689CAF49A3A2321F30F2AB8324C1AC61@FALEX03.au.fjanz.com>
In-Reply-To: <20130206095504.GA31896@boosh.local>
Thread-Topic: [PATCH] rhevm: DTACLOUD-452: expose create_image action only
 when stopped
Thread-Index: Ac4EUCtzQkbsSmPOT7mbMK85EIcafQAAKC2Q
References: <1360116563-5588-1-git-send-email-diesk@fast.au.fujitsu.com>
 <20130206095504.GA31896@boosh.local>
From: "Koper, Dies" <diesk@fast.au.fujitsu.com>
To: <dev@deltacloud.apache.org>

Thanks. Pushed as 8d3868244fd0666c43a1811eb4205e4639f7f221

Regards,
Dies Koper


> -----Original Message-----
> From: Michal Fojtik [mailto:mfojtik@redhat.com]
> Sent: Wednesday, 6 February 2013 8:55 PM
> To: dev@deltacloud.apache.org
> Subject: Re: [PATCH] rhevm: DTACLOUD-452: expose create_image action
only
> when stopped
>=20
> On 02/06, diesk@fast.au.fujitsu.com wrote:
>=20
> ACK!
>=20
>   -- Michal
>=20
> > From: Dies Koper <diesk@fast.au.fujitsu.com>
> >
> > ---
> >  server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > index 69cc563..65ba26d 100644
> > --- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > @@ -254,6 +254,7 @@ class RhevmDriver < Deltacloud::BaseDriver
> >        public_addresses << InstanceAddress.new(inst.vnc[:address],
:port =3D>
> inst.vnc[:port], :type =3D> :vnc)
> >      end
> >
> > +    can_create_image =3D state =3D=3D 'STOPPED'
> >      # Remove 'destroy' operation from list of actions when RHEV-M
instance
> >      # is suspended or paused.
> >      if state =3D=3D 'PAUSED'
> > @@ -261,7 +262,6 @@ class RhevmDriver < Deltacloud::BaseDriver
> >        actions.delete(:destroy)
> >      else
> >        actions =3D instance_actions_for(state)
> > -      can_create_image =3D true
> >      end
> >
> >      Instance.new(
> > @@ -277,7 +277,7 @@ class RhevmDriver < Deltacloud::BaseDriver
> >        :hardware_profile_id =3D> profile.id,
> >        :public_addresses =3D> public_addresses,
> >        :private_addresses =3D> [],
> > -      :create_image =3D> can_create_image || false
> > +      :create_image =3D> can_create_image
> >      )
> >    end
> >
> > --
> > 1.8.0.msysgit.0
> >
> >
>=20
> --
> Michal Fojtik <mfojtik@redhat.com>
> Deltacloud API, CloudForms