Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BE44D028 for ; Thu, 7 Feb 2013 19:20:25 +0000 (UTC) Received: (qmail 17639 invoked by uid 500); 7 Feb 2013 19:20:25 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 17615 invoked by uid 500); 7 Feb 2013 19:20:25 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 17607 invoked by uid 99); 7 Feb 2013 19:20:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Feb 2013 19:20:25 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of lutter@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Feb 2013 19:20:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r17JJvsY010102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Feb 2013 14:19:58 -0500 Received: from [10.3.113.12] ([10.3.113.12]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r17JJvXS031881 for ; Thu, 7 Feb 2013 14:19:57 -0500 Message-ID: <1360264797.3104.49.camel@melon.watzmann.net> Subject: Re: [PATCH core 2/4] CIMI: Capture the validation errors and advertise them as HTTP 400 From: David Lutterkort To: dev@deltacloud.apache.org Date: Thu, 07 Feb 2013 11:19:57 -0800 In-Reply-To: <1360241573-13304-3-git-send-email-mfojtik@redhat.com> References: <1360241573-13304-1-git-send-email-mfojtik@redhat.com> <1360241573-13304-3-git-send-email-mfojtik@redhat.com> Organization: Red Hat Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, 2013-02-07 at 13:52 +0100, mfojtik@redhat.com wrote: > From: Michal Fojtik > > In case when client sent scrumbed XML or JSON body, this patch > will make sure we send 'HTTP 400 - Bad Request' back instead of > horrible looking 500 error. > > This patch also properly advertise the ValidationError in case > when client want to create CIMI resource but the validation conditions > are not met. Heh .. ok; should have looked at all the patches first. That addresses a lot of what I said about reporting errors. Still, would be nice if we reported all validation errors in one shot. David