deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: [PATCH] [Core] - minor typo on realms xml view - DTACLOUD-460
Date Mon, 11 Feb 2013 14:50:27 GMT
On 08/02/13 20:23, David Lutterkort wrote:
> On Fri, 2013-02-08 at 19:38 +0200, marios@redhat.com wrote:
>> From: marios <marios@redhat.com>
>>
>> https://issues.apache.org/jira/browse/DTACLOUD-460
>>
>> Signed-off-by: marios <marios@redhat.com>
>> ---
>>  server/views/realms/show.xml.haml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/server/views/realms/show.xml.haml b/server/views/realms/show.xml.haml
>> index 268cb65..54052a4 100644
>> --- a/server/views/realms/show.xml.haml
>> +++ b/server/views/realms/show.xml.haml
>> @@ -9,6 +9,6 @@
>>      %limit<
>>        =cdata do
>>          =@realm.limit
>> -  - @realm.resource_types.each do |r|
>> +  - (@realm.resource_types || []).each do |r|
> 
> ACK(ish) .. IMHO, better would be to make sure that
> @realm.resource_types always returns an array, and never nil.
> 

right - pushed as http://tracker.deltacloud.org/set/309

marios


> David
> 
> 


Mime
View raw message