deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH] More verbose response for internal errors
Date Wed, 20 Feb 2013 16:42:39 GMT
On 02/20, jprovazn@redhat.com wrote:

ACK. Can you please confirm that you have signed ICLA[1] before we can push
this patch?

[1] http://www.apache.org/licenses/icla.txt

  -- Michal

> From: Jan Provaznik <jprovazn@redhat.com>
> 
> If an exception is raised in a driver and the request is being processed by
> "standard_index_operation" (most of index actions), then a user gets back
> only not very descriptive "Internal server error" message. The exception
> is not logged.
> 
> Fixes https://issues.apache.org/jira/browse/DTACLOUD-489
> ---
>  server/lib/deltacloud/helpers/deltacloud_helper.rb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/lib/deltacloud/helpers/deltacloud_helper.rb b/server/lib/deltacloud/helpers/deltacloud_helper.rb
> index bb023af..b594504 100644
> --- a/server/lib/deltacloud/helpers/deltacloud_helper.rb
> +++ b/server/lib/deltacloud/helpers/deltacloud_helper.rb
> @@ -76,7 +76,7 @@ module Deltacloud::Helpers
>            format.json { JSON::dump({ model => @elements.map { |el| el.to_hash(self)
}}) }
>          end
>        else
> -        report_error(@exception.respond_to?(:code) ? @exception.code : 500)
> +        report_error(@exception.respond_to?(:code) ? @exception.code : nil)
>        end
>      end
>  
> -- 
> 1.7.11.7
> 

-- 
Michal Fojtik <mfojtik@redhat.com>
Deltacloud API, CloudForms

Mime
View raw message