deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH 2/2] renaming vsp to network and removing CIMI client vsp view files
Date Wed, 20 Feb 2013 00:40:04 GMT
On Mon, 2013-02-18 at 15:27 +0300, martha.c.chumo@gmail.com wrote:
> From: NjeriChelimo <martha.c.chumo@gmail.com>
> 
> ---
>  clients/cimi/app.rb                    |    4 ----
>  clients/cimi/lib/entities.rb           |    3 ---
>  server/lib/cimi/models/network_port.rb |   34 ++++++++++++++++----------------
>  3 files changed, 17 insertions(+), 24 deletions(-)

I am confused by this patch: VSP was short for 'virtual switch port'
which was replaced by 'networkPort' .. I believe you meant to change
things like vspTemplate -> networkPortTemplate.

Also:

> diff --git a/clients/cimi/lib/entities.rb b/clients/cimi/lib/entities.rb
> index c5c40df..6529486 100644
> --- a/clients/cimi/lib/entities.rb
> +++ b/clients/cimi/lib/entities.rb
> @@ -38,6 +38,3 @@ require 'entities/network_port_template'
>  require 'entities/network_template'
>  require 'entities/routing_group'
>  require 'entities/routing_group_template'
> -require 'entities/vsp'
> -require 'entities/vsp_configuration'
> -require 'entities/vsp_template'

It seems something needs to be done with the underlying files, too ..
maybe 'git mv' so that it does a s/vsp/networkPort/ together with the
required changes to the contents of the files ?

David



Mime
View raw message