deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 4/4] Tests: Use 'initializers' in all our tests.
Date Sat, 16 Feb 2013 00:06:09 GMT
On Fri, 2013-02-15 at 11:36 +0100, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> This patch will make possible to run our unit-tests without
> initializing the Deltacloud.configure classes, because we already
> do that in initializers.
> 
> For CIMI tests, this will make sure the database directory exists.

ACK.

Comments inline:

> diff --git a/server/tests/cimi/collections/cloud_entry_point_test.rb b/server/tests/cimi/collections/cloud_entry_point_test.rb
> index eed8721..a7fdd89 100644
> --- a/server/tests/cimi/collections/cloud_entry_point_test.rb
> +++ b/server/tests/cimi/collections/cloud_entry_point_test.rb
> @@ -18,7 +18,7 @@ describe CIMI::Collections::CloudEntryPoint do
>    it 'set the CIMI-Version header' do
>      get root_url
>      headers['CIMI-Specification-Version'].wont_be_nil
> -    headers['CIMI-Specification-Version'].must_equal '1.0.0'
> +    headers['CIMI-Specification-Version'].must_equal Deltacloud::CIMI_API_VERSION

You can actually completely remove this header - CIMI 1.0.1 doesn't
mention it anymore, as we've revamped how versioning is done.

David



Mime
View raw message