Return-Path: 
 <dev-return-7511-apmail-deltacloud-dev-archive=deltacloud.apache.org@deltacloud.apache.org>
X-Original-To: apmail-deltacloud-dev-archive@www.apache.org
Delivered-To: apmail-deltacloud-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DC416E134
	for <apmail-deltacloud-dev-archive@www.apache.org>;
 Thu, 17 Jan 2013 14:36:24 +0000 (UTC)
Received: (qmail 74599 invoked by uid 500); 17 Jan 2013 14:36:24 -0000
Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org
Received: (qmail 74514 invoked by uid 500); 17 Jan 2013 14:36:24 -0000
Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@deltacloud.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@deltacloud.apache.org>
List-Post: <mailto:dev@deltacloud.apache.org>
List-Id: <dev.deltacloud.apache.org>
Reply-To: dev@deltacloud.apache.org
Delivered-To: mailing list dev@deltacloud.apache.org
Received: (qmail 74486 invoked by uid 99); 17 Jan 2013 14:36:23 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2013 14:36:23 +0000
Date: Thu, 17 Jan 2013 14:36:23 +0000 (UTC)
From: "Ronelle Landy (JIRA)" <jira@apache.org>
To: dev@deltacloud.apache.org
Message-ID: <JIRA.12627815.1358336801324.152288.1358433383630@arcas>
In-Reply-To: <JIRA.12627815.1358336801324@arcas>
References: <JIRA.12627815.1358336801324@arcas>
Subject: [jira] [Commented] (DTACLOUD-418) Missing href-attribute in JSON
 output
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DTACLOUD-418?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13=
556214#comment-13556214 ]=20

Ronelle Landy commented on DTACLOUD-418:
----------------------------------------

Applying patch set 258 above, and doing a GET on /api/instance/inst_id, the=
 XML and JSON match - short of one element - 'create_image' - it's missing =
on the XML. JSON and XML responses are copied below:

{"instance":
{"private_addresses":[{"type":"hostname","address":"img1.inst1.private.com"=
}],
"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instances/inst1",
"authentication_type":"key",
"storage_volumes":[],
"realm":{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/realms/u=
s","rel":"realm","id":"us"},
"image":{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/images/i=
mg3","rel":"image","id":"img3"},
"state":"RUNNING",
"hardware_profile":{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/a=
pi/hardware_profiles/m1-small","rel":"hardware_profile","properties":{},"id=
":"m1-small"},
"actions":[{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/insta=
nces/inst1/reboot","method":"post","rel":"reboot"},
{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instances/inst1/=
stop","method":"post","rel":"stop"},
{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instances/inst1/=
run;id=3Dinst1","method":"post","rel":"run"},
{"href":"http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/images;instance_=
id=3Dinst1","method":"post","rel":"create_image"}],
"owner":"mockuser",
"name":"MockUserInstance",
"public_addresses":[{"type":"hostname","address":"img1.inst1.public.com"}],
"id":"inst1",
"create_image":true}
}
=20
=20
<instance href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instanc=
es/inst1' id=3D'inst1'>
  <name>MockUserInstance</name>
  <owner_id>mockuser</owner_id>
  <image href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/images/i=
mg3' id=3D'img3'></image>
  <realm href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/realms/u=
s' id=3D'us'></realm>
  <state>RUNNING</state>
  <hardware_profile href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/a=
pi/hardware_profiles/m1-small' id=3D'm1-small'>
  </hardware_profile>
  <actions>
    <link href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instanc=
es/inst1/reboot' method=3D'post' rel=3D'reboot' />
    <link href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instanc=
es/inst1/stop' method=3D'post' rel=3D'stop' />
    <link href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/instanc=
es/inst1/run;id=3Dinst1' method=3D'post' rel=3D'run' />
    <link href=3D'http://cloud-qe-7.idm.lab.bos.redhat.com:3001/api/images;=
instance_id=3Dinst1' method=3D'post' rel=3D'create_image' />
  </actions>
  <public_addresses><address type=3D'hostname'>img1.inst1.public.com</addre=
ss></public_addresses>
  <private_addresses><address type=3D'hostname'>img1.inst1.private.com</add=
ress></private_addresses>
  <storage_volumes></storage_volumes>
  <authentication type=3D'key'>
  </authentication>
</instance>=20

I'm inclined to ACK the patch set because it addresses what's missing from =
JSON and work whether the XML should include 'create_image' in another issu=
e.
               =20
> Missing href-attribute in JSON output
> -------------------------------------
>
>                 Key: DTACLOUD-418
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-418
>             Project: DeltaCloud
>          Issue Type: Bug
>          Components: Server
>         Environment: Debian 6.0.6, ruby 1.9.2p0, deltacloud development
>            Reporter: Christian Karnath
>            Assignee: Michal Fojtik
>
> The 'href' attribute was present in Deltacloud 1.0.2 but it is missing in=
 the current development version when specifying JSON as an output format:
> Requesting /api/instances against deltacloud 1.0.2 returned:
> {
>     "instances": {
>         "instance": {
>             "name": null,
>             "owner_id": "mockuser",
>             "image": { =E2=80=A6 },
>             "realm": { =E2=80=A6 },
>             "state": "RUNNING",
>             "hardware_profile": { =E2=80=A6 },
>             "actions": { =E2=80=A6 },
>             "public_addresses": { =E2=80=A6 },
>             "private_addresses": { =E2=80=A6 },
>             "storage_volumes": null,
>             "authentication": { =E2=80=A6 },
>             "href": "https://192.168.23.101:3001/api/instances/inst0",
>             "id": "inst0"
>         }
>     }
> }
> Requesting /api/instances against deltacloud development version returns:
> {
>     "instances": [
>         {
>             "id": "inst1",
>             "name": "MockUserInstance",
>             "state": "RUNNING",
>             "owner": "mockuser",
>             "image": { =E2=80=A6 },
>             "realm": { =E2=80=A6 },
>             "actions": [ =E2=80=A6 ],
>             "instance_profile": { =E2=80=A6 },
>             "public_addresses": [ =E2=80=A6 ],
>             "private_addresses": [ =E2=80=A6 ],
>             "launch_time": null,
>             "create_image": true,
>             "storage_volumes": [ ]
>         }
>     ]
> }
> It seems that /api/images, /api/realms and so on are also inconsistent wi=
th the corresponding xml representation (which includes the 'href'-attribut=
e).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira