Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F64CED13 for ; Thu, 17 Jan 2013 21:36:13 +0000 (UTC) Received: (qmail 95493 invoked by uid 500); 17 Jan 2013 21:36:13 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 95456 invoked by uid 500); 17 Jan 2013 21:36:13 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 95442 invoked by uid 99); 17 Jan 2013 21:36:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2013 21:36:13 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jvlcek@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2013 21:36:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HLZjZx008506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 16:35:45 -0500 Received: from [10.16.187.164] (dhcp-187-164.bos.redhat.com [10.16.187.164]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HLZhDj023953 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 17 Jan 2013 16:35:44 -0500 Message-ID: <50F86EDA.5030600@redhat.com> Date: Thu, 17 Jan 2013 16:36:26 -0500 From: jvlcek Reply-To: jvlcek@redhat.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: dev@deltacloud.apache.org CC: David Lutterkort Subject: Re: DTACLOUD-379 using Marios's 409 solution. References: <1355264833-1154-1-git-send-email-jvlcek@redhat.com> <1355270726.25895.29.camel@avon.watzmann.net> In-Reply-To: <1355270726.25895.29.camel@avon.watzmann.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Virus-Checked: Checked by ClamAV on apache.org On 12/11/2012 07:05 PM, David Lutterkort wrote: > On Tue, 2012-12-11 at 17:27 -0500, jvlcek@redhat.com wrote: >> DTACLOUD-379 using Marios's 409 solution. >> > ACK to this; stylistically, the two patches should be squashed into one, > since after applying 1/2 triggering this error will cause a server error > because of a missing template. > > Also, the commit message is way too terse; it should contain a sentence > on what the problem was (RHEV-M does not allow deletion of templates > that are in use) and what the fix was (propagating the error cleanly) > > Related to this: looking at the XML template for image, we generate > links for 'create_instance' and 'delete_image' unconditionally. That > probably needs to be changed so we only create links for actions that > can currently be performed. > > David > > David, Regarding the last paragraph in the above email. It's not clear to me what conditions Deltacloud should be checking prior to creating the links for image 'create_instance' and 'delete_image'. I think it's back end specific. I know EC2 allows the deletion of an in use AMI but RHEVm doesn't. Can you please explain what you have in mind? Thanks, Joe