Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] Black box tests - check if collection supported before
 creating test resource
Date: Thu, 24 Jan 2013 23:16:14 +1100
Message-ID: <434A0ECB689CAF49A3A2321F30F2AB8324902788@FALEX03.au.fjanz.com>
In-Reply-To: <1359026070-14855-1-git-send-email-marios@redhat.com>
Thread-Topic: [PATCH] Black box tests - check if collection supported before
 creating test resource
Thread-Index: Ac36JBheH0SZgTGOSjiTWhJfjat+IAAAG6SA
References: <1359026070-14855-1-git-send-email-marios@redhat.com>
From: "Koper, Dies" <diesk@fast.au.fujitsu.com>
To: <dev@deltacloud.apache.org>

Hi Marios,

Reviewed and tested to work. ACK with nit:

> +    def collection_supported(name)
> +      return true if api.collections.include?(name.to_sym)
> +      false
> +    end

Why not just:

 +    def collection_supported(name)
 +      api.collections.include?(name.to_sym)
 +    end

Cheers,
Dies Koper


> -----Original Message-----
> From: marios@redhat.com [mailto:marios@redhat.com]
> Sent: Thursday, 24 January 2013 10:15 PM
> To: dev@deltacloud.apache.org
> Subject: [PATCH] Black box tests - check if collection supported
before
> creating test resource
>=20
> From: marios <marios@redhat.com>
>=20
>=20
> Signed-off-by: marios <marios@redhat.com>
> ---
>  tests/deltacloud/buckets_test.rb   | 2 +-
>  tests/deltacloud/instances_test.rb | 2 +-
>  tests/deltacloud/test_setup.rb     | 7 +++++++
>  3 files changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/tests/deltacloud/buckets_test.rb
> b/tests/deltacloud/buckets_test.rb
> index 38fc120..c9ac7f5 100644
> --- a/tests/deltacloud/buckets_test.rb
> +++ b/tests/deltacloud/buckets_test.rb
> @@ -50,7 +50,7 @@ describe 'Deltacloud API buckets collection' do
>      unless res.code =3D=3D 200
>        raise Exception.new("Failed to create blob #{@@my_blob}")
>      end
> -  end
> +  end if collection_supported :buckets
>=20
>    # delete the bucket/blob we created for the tests
>    MiniTest::Unit.after_tests {
> diff --git a/tests/deltacloud/instances_test.rb
> b/tests/deltacloud/instances_test.rb
> index d6a916c..73b5ed2 100644
> --- a/tests/deltacloud/instances_test.rb
> +++ b/tests/deltacloud/instances_test.rb
> @@ -33,7 +33,7 @@ describe 'Deltacloud API instances collection' do
>      end
>      @@my_instance_id =3D (res.xml/'instance')[0][:id]
>      @@created_resources[:instances] << @@my_instance_id
> -  end
> +  end if collection_supported :instances
>=20
>    #stop/destroy the resources we created for the tests
>    MiniTest::Unit.after_tests {
> diff --git a/tests/deltacloud/test_setup.rb
b/tests/deltacloud/test_setup.rb
> index c75b046..b28e456 100644
> --- a/tests/deltacloud/test_setup.rb
> +++ b/tests/deltacloud/test_setup.rb
> @@ -237,6 +237,13 @@ module Deltacloud::Test::Methods
>        end
>      end
>=20
> +    #convenience method for checking if collection :foo is supported:
> +    def collection_supported(name)
> +      return true if api.collections.include?(name.to_sym)
> +      false
> +    end
> +
> +
>      # Only run tests if collection +collection+ supports feature
+name+ in
>      # the current driver. Use inside a 'describe' block. Tests that
are not
>      # run because of a missing collection are marked as skipped
> --
> 1.7.11.7
>=20