deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ronelle Landy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DTACLOUD-441) api tests don't clean up after themselves
Date Thu, 31 Jan 2013 19:43:14 GMT

    [ https://issues.apache.org/jira/browse/DTACLOUD-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568023#comment-13568023
] 

Ronelle Landy commented on DTACLOUD-441:
----------------------------------------

Hi Dies ... below are comments after looking into your response:

wrt the Vsphere failure: Logged DTACLOUD-449. The issue seems to be creating an instance in
Vsphere with no name parameter. Any test that queries available instances will work but ones
that query the actual instance created by the POST command return 'nil'

wrt the Openstack failures: Logged DTACLOUD-450 (as a side note) but we discovered that the
Openstack provider I tested against yesterday had temporarily disabled creating snapshots
(space constraints). 

wrt the "NEW" "PAUSED" states, they exist but should not be expected in the situation these
tests execute in so we can assume a legitimate error if the test fails out on one of these
states - besides the polling times out so the test will not be stuck - ok here.

So, my only real gripe remains with the fgcp-specific comments. I appreciate the intent but
would prefer that these comments went into a commit message rather than in the tests themselves.
This may sound nit-picky but since the tests strive to maintain a  provider-agnostic interoperability
API, anything driver specific is not optimal.

Will keep a watch on performance.

ACK - with the caveat of moving the comments. 

                
> api tests don't clean up after themselves
> -----------------------------------------
>
>                 Key: DTACLOUD-441
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-441
>             Project: DeltaCloud
>          Issue Type: Test
>          Components: Server
>         Environment: Fgcp driver
>            Reporter: Dies Koper
>            Assignee: Ronelle Landy
>            Priority: Minor
>         Attachments: [PATCH] DTACLOUD441-442.eml
>
>
> When running DC api tests (rake tests:deltacloud in root tests folder), the following
is logged at the end (when using with Fgcp):
> CLEANING UP... resources for deletion: {:firewalls=>[], :instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"],
:keys=>[], :images=>[]}
> CLEANUP attempt finished... resources looks like: {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]}
> deltacloud/instances_test.rb:71: Unable to delete all created resources - please check:
{:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]} (Ex
> ception)
>         from deltacloud/instances_test.rb:244:in `call'
>         from deltacloud/instances_test.rb:244:in `to_proc'
>         from D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
`reverse_each'
>         from D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
`autorun'
> The reason it failed to delete them is because it only tried to stop them, not destroy
them. For Fgcp, stopping an instance doesn't destroy it.
> Suggesting to add code that calls the destroy_instance operation on instances after the
stop operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message