deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: fix for DTACLOUD-441 & DTACLOUD-442
Date Wed, 30 Jan 2013 17:10:23 GMT
Hi Dies:

On 30/01/13 08:24, Koper, Dies wrote:
> Hi Marios,
> 
> I've just resent a patch for these issues. Please review the 2nd one
> (the first doesn't apply as I forgot to update my workspace).
> 
> They required changes in the same file and I tested them together but I
> can try splitting the patch up for the two issues if you prefer.
> 
> I've confirmed mock tests still pass, and all instances tests now pass
> on fgcp too.
> 

comments are on the jira ticket - please hold on pushing for now until
Ronelle has a look too

thanks, marios

(general point - not a problem that you're addressing the 2 issues in
one patch - but can you try and keep the tickets updated - like
attaching the patch there and for example including the comments you
made here on the ticket. Just makes it easier if someone stumbles upon
the ticket to follow what was said/done and why.)

> I did get an error from the bucket tests; I haven't seen this error
> before.
> 
> d:\sources\OSS\cloud\deltacloud\tests>rake test:deltacloud TESTOPTS=-v
> d:/sources/OSS/cloud/deltacloud/tests/deltacloud/buckets_test.rb:57:
> uninitialized class variable @@my_bucket in Object (NameError)
>         from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/rest-client-1.6.7/lib/restcli
> ent/abstract_response.rb:48:in `call'
>         from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/rest-client-1.6.7/lib/restcli
> ent/abstract_response.rb:48:in `to_proc'
>         from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/u
> nit.rb:782:in `reverse_each'
>         from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/u
> nit.rb:782:in `autorun'
> rake aborted!
> Command failed with status (1): [ruby -I"lib"
> -I"D:/programs/Ruby187/lib/ruby/gems/1.8/gems/rake-10.0.3/lib"
> "D:/programs/Ruby187/lib/r
> uby/gems/1.8/gems/rake-10.0.3/lib/rake/rake_test_loader.rb"
> "deltacloud/base_api_test.rb" "deltacloud/buckets_test.rb"
> "deltacloud/hard
> ware_profiles_test.rb" "deltacloud/images_test.rb"
> "deltacloud/instance_states_test.rb" "deltacloud/instances_test.rb"
> "deltacloud/keys
> _test.rb" "deltacloud/realms_test.rb"
> "deltacloud/storage_snapshots_test.rb"
> "deltacloud/storage_volumes_test.rb" -v]
> 
> Cheers,
> Dies Koper
> 
> 
> 


Mime
View raw message