deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 3/3] CIMI: Report sub-collection :href attribute properly (DTACLOUD-433)
Date Sat, 26 Jan 2013 01:00:48 GMT
On Wed, 2013-01-23 at 16:51 +0100, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>

NACK because there is no test that verifies that JIRA 433 is indeed
fixed. Other than that, the patch looks fine with one small nit:

> diff --git a/server/lib/cimi/models/base.rb b/server/lib/cimi/models/base.rb
> index 1393ae4..7995e07 100644
> --- a/server/lib/cimi/models/base.rb
> +++ b/server/lib/cimi/models/base.rb
> @@ -185,12 +185,20 @@ class CIMI::Model::Resource
>    def initialize(values = {})
>      names = self.class.schema.attribute_names
>      @filter_attrs = values[:filter_attr_list] || []
> +    # Make sure we always have the :id of the entity even
> +    # the $select parameter is used and :id is filtered out
> +    #
> +    @_base_id = values[:base_id] || values[:id]

Why is this called @_base_id rather than @base_id ?

David



Mime
View raw message