deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH] Black box tests - check if collection supported before creating test resource
Date Fri, 25 Jan 2013 00:17:16 GMT
On Thu, 2013-01-24 at 13:14 +0200, marios@redhat.com wrote:
> From: marios <marios@redhat.com>
> 
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
>  tests/deltacloud/buckets_test.rb   | 2 +-
>  tests/deltacloud/instances_test.rb | 2 +-
>  tests/deltacloud/test_setup.rb     | 7 +++++++
>  3 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/deltacloud/buckets_test.rb b/tests/deltacloud/buckets_test.rb
> index 38fc120..c9ac7f5 100644
> --- a/tests/deltacloud/buckets_test.rb
> +++ b/tests/deltacloud/buckets_test.rb
> @@ -50,7 +50,7 @@ describe 'Deltacloud API buckets collection' do
>      unless res.code == 200
>        raise Exception.new("Failed to create blob #{@@my_blob}")
>      end
> -  end
> +  end if collection_supported :buckets

It would be much more readable if you replaced the 'begin' for this
block with 'if collection_supported :buckets'

David



Mime
View raw message