Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C604CD2FA for ; Wed, 5 Dec 2012 01:01:21 +0000 (UTC) Received: (qmail 39568 invoked by uid 500); 5 Dec 2012 01:01:21 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 39553 invoked by uid 500); 5 Dec 2012 01:01:21 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 39539 invoked by uid 99); 5 Dec 2012 01:01:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2012 01:01:21 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of lutter@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2012 01:01:15 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB510rRj010686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Dec 2012 20:00:53 -0500 Received: from [10.67.116.22] (ovpn-116-22.sin2.redhat.com [10.67.116.22]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB510oSk016247 for ; Tue, 4 Dec 2012 20:00:52 -0500 Message-ID: <1354669249.3855.7.camel@melon.watzmann.net> Subject: Re: [PATCH 1/2] CIMI - Adds Volume creation with template and config by value - DTACLOUD-385 From: David Lutterkort To: dev@deltacloud.apache.org Date: Tue, 04 Dec 2012 17:00:49 -0800 In-Reply-To: <1354623788-23863-2-git-send-email-marios@redhat.com> References: <1354623788-23863-1-git-send-email-marios@redhat.com> <1354623788-23863-2-git-send-email-marios@redhat.com> Organization: Red Hat Inc Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, 2012-12-04 at 14:23 +0200, marios@redhat.com wrote: > From: marios > > https://issues.apache.org/jira/browse/DTACLOUD-385 > > Signed-off-by: marios > --- > server/lib/cimi/collections/volumes.rb | 11 +++------- > server/lib/cimi/helpers/cimi_helper.rb | 39 ++++++++++++++++++++++++++++++---- > server/lib/cimi/models/volume.rb | 37 +++++++++++++++++++------------- > 3 files changed, 60 insertions(+), 27 deletions(-) Thanks for the quick turnaround; please also add a unit test that demonstrates that this now works. David